Finished Math Game

[rumanstheddy]

No description provided.

[TheCSharpAcademy]

@rumanstheddy Thanks for submitting! The project is looking good but there a couple of things I need you to address before I can approve. These aren't requirements but they'll be a good learning opportunity for you:

1️⃣The game is very limited if you're hard coding the questions. You can easily generate Random questions in C#.

2️⃣At the moment there's no input validation, so if I input something wrong the app crashes. Don't use recursion, use a loop for the validation.

3️⃣Your ShowMenu() calls StartGame(). StartGame() calls ShowMenu(). That's an endless recursion that means that each time a method is called it stays in the stack, occupying a little extra memory. While this is not a big issue in a small app, a few more methods and collections would quickly add up to a stack overflow. For that reason recursion isn't good practice in most cases.

Could you please fix these before I can approve? 😀Let me know if you have questions.

[rumanstheddy]

Thank you so much for taking the time to review these changes!
I will fix them and let you know.

[rumanstheddy]

@TheCSharpAcademy, I have implemented the fixes you suggested.
Please take a look at them and let me know what you think, once you find the time.
Thank you so much!

[TheCSharpAcademy]

@rumanstheddy Thanks for making the changes! There's still one problem. The divisions are crashing sometimes. Try playing the division game a few times and see if your app stops like this:





I suspect there's something wrong with the ranges of your division when a = 1 or a = 2.

[rumanstheddy]

@TheCSharpAcademy Thank you so much for reviewing the code again!
I have fixed the issue, now 'a' will always be divisible by 'b'.