Skip to content

Don't create ~/DuckGame#73

Draft
Damglador wants to merge 1 commit intoTheFlyingFoool:masterfrom
Damglador:master
Draft

Don't create ~/DuckGame#73
Damglador wants to merge 1 commit intoTheFlyingFoool:masterfrom
Damglador:master

Conversation

@Damglador
Copy link
Copy Markdown

It has been over 5 years since the location changed, there's no reason to keep creating this directory.

It has been over 5 years since the location changed, there's no reason to keep creating this directory.
@othello777
Copy link
Copy Markdown
Collaborator

You have a good point, but this project's goal is to build on top of legacy code and remove as little as possible from the original game, so this doesn't really align with the project's goal. Thanks for the effort in any case

@othello777 othello777 closed this Mar 6, 2026
@TheFlyingFoool
Copy link
Copy Markdown
Owner

The code in question for anyone it has run for before only runs DirectoryExists and File.Exists.
Which is fairly light weight and we would rather support more than less. and the DirectoryCopy is useful for people who use -alternateSaveLocation.

@Damglador
Copy link
Copy Markdown
Author

Okay, so would it be fine if I add a "-dontCreateOldDir" flag, or something like that, which would be optional, so it theoretically shouldn't break anything unless people opt-in. Because as currently that code will ensure you always have a useless ~/DuckGame folder at all times, as it gets triggered regardless of if the new directory already exists or not, which is quite annoying.

@othello777
Copy link
Copy Markdown
Collaborator

Sure, that would work actually.

@othello777 othello777 reopened this Mar 6, 2026
@othello777 othello777 marked this pull request as draft March 16, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants