Include matching attribute in SAML patron ID extraction logging. #2950
+106
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2950 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 454 454
Lines 42840 42844 +4
Branches 5975 5976 +1
=======================================
+ Hits 39748 39752 +4
Misses 2021 2021
Partials 1071 1071 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonathangreen
approved these changes
Jan 6, 2026
Member
jonathangreen
left a comment
jonathangreen
left a comment
There was a problem hiding this comment.
Added a minor suggestion
| if patron_id is None: | ||
| self._logger.error( | ||
| f"Failed to extract a unique patron ID {attribute_origin}" | ||
| f"Failed to extract a unique patron ID from {attribute_origin}" |
Member
There was a problem hiding this comment.
Very (very) minor suggestion to remove "a" to match the other log message on line 1395.
Suggested change
| f"Failed to extract a unique patron ID from {attribute_origin}" | |
| f"Failed to extract unique patron ID from {attribute_origin}" |
Contributor
Author
There was a problem hiding this comment.
I did this on purpose. The sentences aren't parallel because I'm naming the ID on l. 1395 (though they would've been had I mentioned the ID parenthetically there).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log messages for successful extraction of a patron ID from a SAML Subject will now include the name of the attribute from which the patron ID was extracted. It will instead include the string "NameID" if we did not have an attribute match, but were able to fall back to the
nameID.Motivation and Context
It is helpful to know which attribute provided the patron ID, especially for configurations in which different attributes might sometimes provide the same value.
How Has This Been Tested?
Checklist