manage_entities_data: Implement publisher output#305
Draft
michaelwood wants to merge 1 commit intolivefrom
Draft
manage_entities_data: Implement publisher output#305michaelwood wants to merge 1 commit intolivefrom
michaelwood wants to merge 1 commit intolivefrom
Conversation
This requires making certain fields optional while grantnav transitions from using publisher data tacked on to the funder object. This solves the problem of grantnav using a provenance file for publisher data and once grantnav is updated to use publisher.jsonl the issue of duplicate publishers from different datagetter runs caused by the tacking on of the publisher data to funders. Note database migration to add further common field into Entity class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires making certain fields optional while grantnav transitions from using publisher data tacked on to the funder object.
This solves the problem of grantnav using a provenance file for publisher data and once grantnav is updated to use publisher.jsonl the issue of duplicate publishers from different datagetter runs caused by the tacking on of the publisher data to funders.
Note database migration to add further common field into Entity class.