basic implementation to enable remote iri over https#21
Open
heavyengineer wants to merge 2 commits intoTimSamshuijzen:masterfrom
Open
basic implementation to enable remote iri over https#21heavyengineer wants to merge 2 commits intoTimSamshuijzen:masterfrom
heavyengineer wants to merge 2 commits intoTimSamshuijzen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes enable the user to supply an https url for the remote iri.
This works by adding two options to the configuration - provider and protocol. This enables the user to supply a single configuration string e.g. "https://field.carriota.com:443" or the current way with host, port and now protocol. The existing configuration options will still work.
If host is populated, then port and protocol are optional and default to port 80 and http:
When the request to the remote iri service begins it uses the appropriate http or https method.
I haven't supplied any tests yet but will if i continue to build on the s/w.