-
-
Notifications
You must be signed in to change notification settings - Fork 49
A couple additions #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
A couple additions #273
Conversation
This tutorial contains an example with multiple indexes and subsequent tampering to the data in order to show resiliency and a real life use case of TC applied on cryptocurrency prices up to 2021.
Fix to the issue raised on empty dataframe, resulting from an inner merge where the existing dataframe that accumulated results and the newer one had diferent indices. A subsequent issue must be raised to either: 1 report a single model failure (on index matching) 2 fix the moirai discrepancy (only model that showed this issue)
AzulGarza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice tutorial and thanks for the merge fix, @elmartinj! would you mind checking the style ci/cd breaking? uv pre-commit run --all-files and commiting the output files should be fix the error.
AzulGarza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much, @elmartinj! would it be great if you could make the following changes:
- change the nb from
docs/getting-startedtodocs/examples/. that's where other examples lie. also would it be possible to use middle dash (-) for naming files? just to be consistent across the project. - add the nb to the documentation. this can be done adding the file path here:
Lines 21 to 29 in a9ce43e
| - Examples: | |
| - examples/agent-quickstart.ipynb | |
| - examples/llm-providers.ipynb | |
| - examples/aws-bedrock.ipynb | |
| - examples/forecaster-quickstart.ipynb | |
| - examples/anomaly-detection-forecaster-quickstart.ipynb | |
| - examples/ts-foundation-models-comparison-quickstart.ipynb | |
| - examples/gift-eval.ipynb | |
| - examples/chronos-family.ipynb |
- what do you think about using
TimeCopilot Forecaster for Cryptocurrencyas title? - some of the cells are a little bit verbose, could we remove the output of them?
|
Hello! Just submitted the changes. The verbose part is a bit more complicated due to execution time, so TBD (?) |
AzulGarza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much, @elmartinj! we are almost there. the only thing that is left is that we want to show the example in our documentation, under the examples section. thanks for changing the name. i think now we can rename the name of the file to examples/cryptocurrency-quickstart.ipynb. and then, to make it public in our docs, you need to add examples/cryptocurrency-quickstart.ipynb to the mkdocs.yml file, here:
Lines 21 to 29 in a9ce43e
| - Examples: | |
| - examples/agent-quickstart.ipynb | |
| - examples/llm-providers.ipynb | |
| - examples/aws-bedrock.ipynb | |
| - examples/forecaster-quickstart.ipynb | |
| - examples/anomaly-detection-forecaster-quickstart.ipynb | |
| - examples/ts-foundation-models-comparison-quickstart.ipynb | |
| - examples/gift-eval.ipynb | |
| - examples/chronos-family.ipynb |
Minor bug fix on the indexing from issue 262 (now closed).
Created a small tutorial that shows resiliency on missing data and several unique_ids on a single dataframe.