Extra examples from Musketeer work#1
Open
ms705 wants to merge 19 commits intoTimelyDataflow:release_0.5from
Open
Extra examples from Musketeer work#1ms705 wants to merge 19 commits intoTimelyDataflow:release_0.5from
ms705 wants to merge 19 commits intoTimelyDataflow:release_0.5from
Conversation
|
I am fine with adding these examples, but it might make sense to merge them with the fault tolerance branch which is really the active development branch now (e.g. it includes the improved graphlinq, as well as the fault tolerance work) instead of release_0.5. We should figure out what to do so that it builds with Mono without removing the Windows-only projects too. |
Author
|
Good points. I'll remove the changes that break the Windows build and rebase the PR onto the development branch. The only argument in favour of merging this into release_0.5 is that the new examples would become available in the stable branch even before the 0.6 release is cut from the development branch. I'm happy to go either way :) |
frameworks (which work on Windows only, as they require Peloponnese.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request brings in some extra Naiad example jobs developed at Cambridge for the Musketeer paper (dl.acm.org/citation.cfm?id=2741968):
The implementations are hand-written Naiad baselines, not auto-generated jobs from Musketeer. We used these jobs as our baselines in the paper.
We may need to do some code cleanup and add better documentation in order to merge these, but I thought it'd be best to open a PR and start the discussion, so that we can track changes here.