Conversation
replacing the time.cc file with - time_napi.cc - time_napi.h files also using the object wrapper methodology from the workshop at Node Summit.
1 outstanding unit test failing. binding.gyp changed to handle the gmtOffset in localtime
did not find a standard so 4 spaces is adopted
the Time::time method was not used.
set version to 1.0.0
travis ci testing.
…ms differed. do not unit test on windows as the original nan code had issues.
|
Additionally I published locally using verdaccio and used the package locally. |
|
ok, I did not see the appveyor build and will address it. |
|
Nathan, I have checked over the AppVeyor build history and the unit tests have not previously passed on windows. May I suggest that as this has been the case for a long time that this not stop the upgrade from NAN to NAPI. The build on windows does work. |
| - "7" | ||
| - "8" | ||
| - "10" | ||
| - "node" |
There was a problem hiding this comment.
We should also test 11 for now I think
There was a problem hiding this comment.
yes, node means the latest node and that presently is 11.6.0.
package.json
Outdated
| "mocha": "*" | ||
| } | ||
| }, | ||
| "gypfile": true |
There was a problem hiding this comment.
I'm not sure that this is required. npm adds it implicitly to the package metadata with the presence of a binding.gyp file.
There was a problem hiding this comment.
checking it out ...
Im sure you are correct.
There was a problem hiding this comment.
yes indeed so, it was in the first hello-world example for NAPI conversion but in no others from the workshop I looked at. I'll raise a PR on the workshop too.
|
Ok, I’ll change it to latest. Node is an alias for latest.
Sent from my iPhone
On Jan 14, 2019, at 9:52 PM, Nathan Rajlich ***@***.***> wrote:
@TooTallNate commented on this pull request.
In .travis.yml:
>
language: node_js
node_js:
- - "0.8"
- - "0.10"
- - "0.12"
- - "1"
- - "2"
- - "3"
- - "4"
- - "5"
- - "6"
- - "7"
+ - "8"
+ - "10"
+ - "node"
What is this version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
I just checked and "node" just means the latest node version on travis which was 11.6.0 at the time of the build. It looks like they do not have a "latest".
|
…gyp serves this purpose now.
…very latest node ( currently 11.6.0 )
|
any chance to look at my responses to your questions? |
|
its still here, build on windows was previously broken too. But I think this PR is still valid. |
2 participants
This is a conversion from use of the nan to the node-addon-api ( which is for the napi interface ).
The travis file has been updated for linux, osx and windows. There were issues with unit tests on windows. These pre-dated these changes as I do not think windows was available on travis at the time the module was created.