Fixes #112 deprecated V8 API usage (also updates documentation from using var to const)#113
Fixes #112 deprecated V8 API usage (also updates documentation from using var to const)#113riyadshauk wants to merge 3 commits intoTooTallNate:masterfrom
Conversation
|
You are a god. Thank you so much for fixing this and making my life a lot easier! |
|
Yeah, no problem. Like I said in the linked issue, just for the time being, until this repo is fixed, you can use this in your package.json: |
|
@riyadshauk your fix addressed the blocker I encountered while upgrading the version of Node from 8.12 to 12.16 (LTS) on a old monolith project, thank you for taking the time to solve the problem! @TooTallNate I know OSS maintenance is a thankless job, but if I ask nicely, can we get a little bit of attention over here to review & accept this PR? Pointing to @riyadshauk's Github Repo in the package.json manifest is a security vulnerability that I'd rather not introduce into my production app & I'd like to avoid forking the solution to republish a completely new npm package |
Thank you! |

For reference on currently acceptable V8 API usage:
bcoin-org/bcrypto#7
nodejs/node@7ce749d722
and of course: https://docs.google.com/document/d/1g8JFi8T_oAE_7uAri7Njtig7fKaPDfotU6huOa1alds/edit
The above resources were used to fix the breaking, deprecated usage of the V8 API in time.cc.
Please pull my changes into master : )