Skip to content

add pyrpc to mc_bytes_packet#207

Merged
STYLE-STARS merged 9 commits intoToolDelta-Basic:mainfrom
STYLE-STARS:main
Mar 22, 2026
Merged

add pyrpc to mc_bytes_packet#207
STYLE-STARS merged 9 commits intoToolDelta-Basic:mainfrom
STYLE-STARS:main

Conversation

@STYLE-STARS
Copy link
Collaborator

No description provided.

@deepsource-io
Copy link
Contributor

deepsource-io bot commented Feb 22, 2026

DeepSource Code Review

We reviewed changes in 9383271...3ae23e8 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Mar 22, 2026 11:14a.m. Review ↗
Shell Mar 22, 2026 11:14a.m. Review ↗
Docker Mar 22, 2026 11:14a.m. Review ↗

@Happy2018new
Copy link
Member

Happy2018new commented Feb 22, 2026

And also, you missed these two constants.

const (
	PyRpcOperationTypeSend = 0x05db23ae
	PyRpcOperationTypeRecv = 0x0094d408
)

You better move these two constants from tooldelta/constants/netease.py to your py file.

image

@STYLE-STARS
Copy link
Collaborator Author

@Happy2018new All issues have been resolved

STYLE-STARS and others added 2 commits February 24, 2026 15:56
Co-authored-by: Eternal Crystal <109064184+Happy2018new@users.noreply.github.com>
@STYLE-STARS
Copy link
Collaborator Author

@Happy2018new All issues have been resolved

Copy link
Member

@Happy2018new Happy2018new left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting neomega-core and Plugin Market to change, then this Pull Request can be safe to merge.

@STYLE-STARS STYLE-STARS merged commit a4793c7 into ToolDelta-Basic:main Mar 22, 2026
3 of 4 checks passed
@Happy2018new
Copy link
Member

I'm sorry for that but I have not sync these changes to neomega-core.
So let me revert your changes until I finish that part.

Happy2018new added a commit that referenced this pull request Mar 22, 2026
Happy2018new added a commit that referenced this pull request Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants