Closed
Conversation
quffaro
force-pushed
the
cm/stockflow-dynvar
branch
from
4914bbd to
71cc0ea
Compare
epatters
reviewed
Jul 8, 2025
|
|
||
| /// Simulates the mass-action system derived from a model. | ||
| #[wasm_bindgen(js_name = "mass_action")] | ||
| pub fn mass_action( |
Member
There was a problem hiding this comment.
Remove for now until we have an idea about semantics for system structure diagrams with auxiliary variables: the existing mass action semantics will not use the auxiliary variables at all.
| ustr("Outflow"), | ||
| TabObType::Basic(x), | ||
| th.tabulator(th.hom_type(TabObType::Basic(x))), | ||
| ); |
Member
There was a problem hiding this comment.
As we discussed today, these "inflows" and "outflows" are actually new kinds of links. We decided to punt on inflows/outflows until our theories can be souped up to handle terminal objects.
Member
|
Closing due to staleness. I still think this would be a nice logic to have, even if we're not sure about the quantitative semantics for system structure diagrams with auxiliary variables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an extension of Stock and Flow with auxiliary variables, an object which acts as a functions of quantities of stocks connected to it by variable links. The auxiliary variable acts on flows by a flow link. This effort implements the theory and frontend partially completed in #537, whereas the simulation work will be punted to a new PR.