Run all frontend tests in CI with NixOS VM#816
Merged
Conversation
1a3dd7c to
79aa62c
Compare
194317b to
c272965
Compare
jmoggr
commented
Nov 4, 2025
c6c10b5 to
65cb065
Compare
6b53dd6 to
4ee768f
Compare
4ee768f to
f0472f9
Compare
epatters
requested changes
Nov 24, 2025
Member
epatters
left a comment
There was a problem hiding this comment.
Thanks Jason, it will be great to run the full test suite in CI. Two questions/comments below.
kasbah
reviewed
Nov 25, 2025
f1fd738 to
f74bc73
Compare
510c446 to
5d8701a
Compare
1fbff4f to
51b7a22
Compare
epatters
requested changes
Dec 1, 2025
epatters
approved these changes
Dec 2, 2025
Collaborator
Author
|
I pushed a fix. Steps:
I'll make sure to improve the docs on this
It's possible that there was another instance of something changing and the hash not getting updated. Fortunately this PR should prevent that going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates:
vitesttests from thefrontendpackage.This result is end-to-end tests against a host that was setup from scratch.
I needed to bump the
vitestversion and some follow on dependencies to letvitestrun in a read-only environment.