Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CI/CD for automatic build and push docker image to dockerhub. Build process will appear on the Github Hosted runners.
To make it work you need to provide 3 repository secrets:
REGISTRY_LOGIN- login for dockerhubREGISTRY_PASSWORD- password for dockerhubIMAGE_NAME- fully-qualified name of image e.g.TradeMe/ReviewMeAlso i've changed build behavior in Dockerfile - passing repo files directly insted of installing some version, to make all version control on the github side.
Default strategy will be:
Every commit to
masterbranch will be pushed to$IMAGE_NAME:master, and every tag will be$IMAGE_NAME:$TAG_NAME.Also, i've added creating separate data directory for persistent files -
/var/lib/reviewme, now it used for storing onlypublished_reviews.json.