Merged
Conversation
- GraphQLクエリにcolorフィールドを追加し、路線カラーを取得 - Polylineを路線セグメントごとに分割して各路線の色で描画 - 路線フィルターボタンにもラインカラーを適用 - 軌跡の始点に小さい丸マーカーを追加 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughマップで路線ごとの色を取得・キャッシュし、トラジェクトリーを同一 Changes
Sequence Diagram(s)sequenceDiagram
participant Map as MapComponent
participant Hook as useLineColors
participant Names as useLineNames
participant API as GraphQL
participant Cache as ColorCache
Map->>Hook: lineIds を要求
Hook->>Names: fetchLineNames(lineIds)
Names->>API: lines クエリ(color 含む)を送信
API-->>Names: lineId + color を返す
Names->>Cache: 色を正規化して colorCache に保存
Names-->>Hook: Record<lineId,color> を返却
Hook-->>Map: lineColors を提供
Map->>Map: セグメントごとに色付きでレンダリング
Map->>Map: フィルター・マーカーに lineColors を適用
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
デバイスごとの色分けを廃止し、路線カラーに一本化。 フォールバック色はデフォルトカラーを使用。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Summary by CodeRabbit
リリースノート