fix(logs): FlatListにflex:1を追加しフィルターのスクロール追従を修正#33
Closed
TinyKitten wants to merge 2 commits intomainfrom
Closed
Conversation
フィルターアコーディオンと件数表示をstickyHeaderからFlatListの ListHeaderComponentに移動。タイトルと検索ボックスのみがスクロール 追従で固定表示され、フィルターと件数はリストと一緒にスクロールする。 https://claude.ai/code/session_01MPkqpw4PNwHcRH6Gb74HD9
FlatListにflex:1がないと残りスペースに制約されず、 ListHeaderComponent内のフィルターと件数表示が固定表示のままになっていた。 https://claude.ai/code/session_01MPkqpw4PNwHcRH6Gb74HD9
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughウォークスルーログビューのUI構造を再構成し、フィルター アコーディオンを独立したコンポーネントからFlatListのListHeaderComponentに変更。検索とタイトルは固定的に保持されながら、フィルターUIと件数情報はスクロール可能なリストヘッダー領域に統合されました。 変更内容
推定コードレビュー所要時間🎯 2 (Simple) | ⏱️ ~12 分 関連の可能性があるPR
ウサギからのお祝いの詩
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flex: 1を追加し、スティッキーヘッダー下の残りスペースに制約されるように修正ListHeaderComponent内のフィルターアコーディオンと件数表示がリストと一緒にスクロールするようになったTest plan
https://claude.ai/code/session_01MPkqpw4PNwHcRH6Gb74HD9
Summary by CodeRabbit
リリースノート