Conversation
…nsactionValue Updates the library and CLI to match TAIPs spec changes: - TAIP-17: Rename Escrow message type to Lock. The composable escrow workflow and EscrowAgent role name are preserved; only the message identifier changed (lock + capture mirrors auth/capture in card payments). - TAIP-18: Rename Exchange message type to RFQ (Request for Quote). - TAIP-3: Add optional TransactionValue (amount, currency) for fiat equivalent value, used for Travel Rule threshold determination when an asset is not widely traded. No backwards-compatibility shims; constants, types, constructors, file names, and the `tap message <type>` CLI subcommand are all renamed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
govulncheck flagged 8 fixed-in-1.26.1/1.26.2 vulns in crypto/x509, os, and net/url reachable from cmd/tap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the Go library and CLI in line with recent TAIPs spec changes. No backwards-compatibility shims — constants, types, constructors, file names, and CLI subcommands are renamed in place.
EscrowtoLock(lock + capture mirrors auth/capture in card payments). The composable escrow workflow andEscrowAgentrole name are preserved; only the message identifier changed.TypeEscrow→TypeLock,EscrowBody→LockBody,NewEscrowMessage→NewLockMessageescrow.go/escrow_test.go→lock.go/lock_test.gotap message escrow→tap message lockTypeExchange→TypeRFQ,ExchangeBody→RFQBody,NewExchangeMessage→NewRFQMessageexchange.go/exchange_test.go→rfq.go/rfq_test.gotap message exchange→tap message rfqtransactionValue. Adds optionalTransactionValue(amount,currency) toTransferBodyso receiving agents can determine fiat value for Travel Rule threshold evaluation when the asset isn't widely traded.README.md,CLAUDE.md,doc.go, andCHANGELOG.mdupdated to match.Test plan
go fmt ./...cleango vet ./...cleangolangci-lint run ./...— 0 issuesgo test ./...— library + CLI suites passLocktest vector loads fromTAIPs/test-vectors/lock/valid-lock.jsontransactionValueround-trips throughParseBodyand stays absent (omitempty) when not set🤖 Generated with Claude Code