Skip to content

PositionEmbeddingsAttentionBride forward silently skipped hook#1256

Merged
jlarson4 merged 3 commits intodev-3.x-canaryfrom
bug/position-embeddings-attention-bridge-fix
Apr 15, 2026
Merged

PositionEmbeddingsAttentionBride forward silently skipped hook#1256
jlarson4 merged 3 commits intodev-3.x-canaryfrom
bug/position-embeddings-attention-bridge-fix

Conversation

@jlarson4
Copy link
Copy Markdown
Collaborator

Description

Ensure all hooks are firing as expected. Created a ParallelBlockBridge that handles parallel attention models specifically. Added tests to make sure these errors do not recur.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

@jlarson4 jlarson4 merged commit 43116f2 into dev-3.x-canary Apr 15, 2026
60 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant