Add fields to make ticket simpler to resolve#7
Open
gprice1129 wants to merge 2 commits intoTranslatorSRI:mainfrom
Open
Add fields to make ticket simpler to resolve#7gprice1129 wants to merge 2 commits intoTranslatorSRI:mainfrom
gprice1129 wants to merge 2 commits intoTranslatorSRI:mainfrom
Conversation
Author
|
Do not merge until frontend changes have been completed |
maximusunc
reviewed
Jul 2, 2023
issue_router/models.py
Outdated
| """Schema for a /create_issue request.""" | ||
| title: str | ||
| url: str | ||
| submitter: str |
Collaborator
There was a problem hiding this comment.
One thing to note is that I think this field should be optional. There was discussion when creating this tool about including this field and I believe the conclusion was that feedback submitters should be able to stay anonymous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.