Fix Tool Box menu not rendering by adding missing menuDiv wrapper

[Copilot]

• Analyze the problem and understand the issue
• Identify root cause Contact address for bug reports points to the defunct SourceForge repository  #1: Missing <div id="menuDiv"> wrapper in menu JSP files
• Fix all menu JSP files - Add menuDiv wrapper
• Identify root cause Corrects contact information for reporting bugs #2: permissions="rolesAdapter" incompatible with Spring Security 5.8.15 (related to Struts upgrades)
• Remove permissions="rolesAdapter" from all menu JSP files
• Verify compile succeeds
• Run code review - Passed
• Run security scan - No issues

Summary

The Tool Box menu was not visible on submission pages due to two issues:

1. Missing menuDiv element: JavaScript expected id="menuDiv" for menu initialization
2. Incompatible rolesAdapter: The struts-menu permissions adapter wasn't working after Spring Security migration

Security Note

Access control is still enforced at the URL level by Spring Security (configured in treebase-security.xml). Removing the menu-level filtering is safe - menus provide navigation while Spring Security blocks unauthorized access.

Original prompt

Logged in users who are submitting data should have access to a 'tool box' that should appear dynamically on, for example, the summary page of a study they are submitting. This tool box should contain buttons that link to actions to updating the citation associated with the study, uploading data, etc.

This menu is no longer visible and I don't know where it went. It is seemingly not being rendered in the JSP. I don't remember if it was being made by JavaScript or JSP. I need a very thorough, comprehensive analysis of what might have happened and how we can bring this back.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[rvosa]

@copilot the toggle between the minus and plus gif now works, so renaming the div ID did something - but the menu itself is still empty. This is the HTML that is being rendered in the browser:

<a onclick="switchMenu();" style="cursor: pointer;"><img id="tb" src="../images/minus.gif"/>&nbsp;&nbsp;Tool Box</a>
--
<div id="menuDiv">
<ul class="menuList">
 
 
 
 
 
 
 
 
 
 
 
 
 
</ul>
</div>
<div id="debug"></div>
</div>
</div>
</div>
</div>
<script type="text/javascript">
initializeMenus();
 
function switchMenu() {
var el = document.getElementById('menuDiv');
var tb = document.getElementById('tb');
if ( el.style.display != "none" ) {
el.style.display = 'none';
tb.src="../images/plus.gif";
}
else {
el.style.display = 'block';
tb.src="../images/minus.gif";
}
}
</script>

<a onclick="switchMenu();" style="cursor: pointer;"><img id="tb" src="[../images/minus.gif](http://localhost:8080/treebase-web/images/minus.gif)"/>&nbsp;&nbsp;Tool Box</a>
<div id="menuDiv">
<ul class="menuList">


	
	
	
	
    
    
    
    
    
         
        
 </ul>
</div>
 <div id="debug"></div>
</div>
</div>
</div>
</div>
<script type="text/javascript">
    initializeMenus();

    function switchMenu() {
        var el = document.getElementById('menuDiv');
        var tb = document.getElementById('tb');
        if ( el.style.display != "none" ) {
            el.style.display = 'none';
            tb.src="../images/plus.gif";
                    }
        else {
            el.style.display = 'block';
            tb.src="../images/minus.gif";
                   }
    }
</script>

As you can see, the expected menu items aren't there. So there is something going wrong on the server side. I need you to analyze carefully and comprehensively what that might be. It is NOT in the JavaScript.

[Copilot]

@copilot the toggle between the minus and plus gif now works, so renaming the div ID did something - but the menu itself is still empty. This is the HTML that is being rendered in the browser:

...

You're correct - this is related to the Struts/Spring Security upgrades. The permissions="rolesAdapter" attribute in struts-menu was causing menu items to not render because the RolesPermissionsAdapter relied on Struts integration that's no longer present after migrating to Spring Security 5.8.15.

I've removed the permissions="rolesAdapter" attribute from all four menu JSP files in commit 3a8ec30. This is safe because Spring Security already handles access control at the URL level (e.g., /user/** requires User,Admin,Associate Editor roles) - the menus just provide navigation while Spring Security blocks unauthorized access attempts.