Skip to content

Updated to node 24#403

Merged
9larsons merged 4 commits intomainfrom
upd-node
Mar 2, 2026
Merged

Updated to node 24#403
9larsons merged 4 commits intomainfrom
upd-node

Conversation

@9larsons
Copy link
Collaborator

no ref

24 is latest active LTS
22 is maintenance
20 is EOL in 2 months

no ref

24 is latest active LTS
22 is maintenance
20 is EOL in 2 months
@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between b1b308e and 2a9200e.

📒 Files selected for processing (5)
  • .github/workflows/publish.yml
  • .github/workflows/test.yml
  • .nvmrc
  • packages/express-test/lib/Request.js
  • packages/express-test/package.json
 _______________________________________________________________________________________________________________________________________________________________
< English is just a programming language. Write documents as you would write code: honor the DRY principle, use metadata, MVC, automatic generation, and so on. >
 ---------------------------------------------------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

✏️ Tip: You can disable in-progress messages and the fortune message in your review settings.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upd-node

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons 9larsons enabled auto-merge (squash) February 25, 2026 16:56
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b1b308e) to head (2a9200e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #403   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          133       133           
  Lines         8568      8630   +62     
  Branches      1447      1460   +13     
=========================================
+ Hits          8568      8630   +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ErisDS
Copy link
Member

ErisDS commented Mar 2, 2026

🤖 Velo CI Failure Analysis

Classification: 🟠 SOFT FAIL

  • Workflow: Test
  • Failed Step: Run yarn test:ci
  • Run: View failed run
    What failed: Test suite failure in @tryghost/express-test project
    Why: The logs indicate that the test suite for the @tryghost/express-test project failed, which is a code issue. The failure is not due to any infrastructure-related problems.
    Action:
    The author should investigate the test failures in the @tryghost/express-test project and fix any issues in the code to resolve the CI failure.

@ErisDS
Copy link
Member

ErisDS commented Mar 2, 2026

🤖 Velo CI Failure Analysis

Classification: 🟠 SOFT FAIL

  • Workflow: Test
  • Failed Step: Run yarn test:ci
  • Run: View failed run
    What failed: Test suite for @tryghost/express-test project failed
    Why: The final error in the logs indicates that the test target for the @tryghost/express-test project failed, which is a code issue. This is a soft failure because the error is related to the application code and not an infrastructure problem.
    Action:
    The author should investigate the test failures for the @tryghost/express-test project and fix any issues in the code to resolve the CI failure.

@9larsons 9larsons merged commit 4d63a95 into main Mar 2, 2026
3 of 4 checks passed
@9larsons 9larsons deleted the upd-node branch March 2, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants