Skip to content

Update knex to v3 in prometheus-metrics#425

Merged
9larsons merged 2 commits intomainfrom
fix/knex-v3
Mar 2, 2026
Merged

Update knex to v3 in prometheus-metrics#425
9larsons merged 2 commits intomainfrom
fix/knex-v3

Conversation

@9larsons
Copy link
Collaborator

@9larsons 9larsons commented Mar 2, 2026

Summary

  • Updates knex devDependency from 2.5.1 to 3.1.0 in @tryghost/prometheus-metrics
  • Aligns with @tryghost/database-info which already uses knex 3.1.0

Supersedes #200

Bump the knex devDependency from 2.5.1 to 3.1.0, matching the version
already used by database-info.
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Warning

Rate limit exceeded

@9larsons has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 8e81551 and 6c927a9.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • packages/prometheus-metrics/package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/knex-v3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons 9larsons enabled auto-merge (squash) March 2, 2026 16:18
@9larsons 9larsons merged commit b1b308e into main Mar 2, 2026
4 checks passed
@9larsons 9larsons deleted the fix/knex-v3 branch March 2, 2026 16:20
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8e81551) to head (6c927a9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #425   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          133       133           
  Lines         8568      8568           
  Branches      1447      1447           
=========================================
  Hits          8568      8568           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants