Skip to content

Remove json-stable-stringify from @tryghost/api-framework#428

Merged
9larsons merged 2 commits intomainfrom
remove-json-stable-stringify
Mar 2, 2026
Merged

Remove json-stable-stringify from @tryghost/api-framework#428
9larsons merged 2 commits intomainfrom
remove-json-stable-stringify

Conversation

@9larsons
Copy link
Collaborator

@9larsons 9larsons commented Mar 2, 2026

Summary

  • Replace json-stable-stringify with an inline JSON.stringify(obj, Object.keys(obj).sort()) at the single call site (cache key generation in pipeline.js)
  • Remove the dependency from package.json

Test plan

  • All 109 tests pass
  • 100% code coverage maintained

9larsons added 2 commits March 2, 2026 11:48
Inline JSON.stringify with sorted keys at the single call site where
it was used (cache key generation). No need for a separate dependency.
@9larsons 9larsons enabled auto-merge (squash) March 2, 2026 17:49
@9larsons 9larsons disabled auto-merge March 2, 2026 17:49
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 805f4f0 and 516f850.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • packages/api-framework/lib/pipeline.js
  • packages/api-framework/package.json
 ________________________________________________
< Love the optimism of `// should never happen`. >
 ------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

✏️ Tip: You can disable in-progress messages and the fortune message in your review settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-json-stable-stringify

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons 9larsons enabled auto-merge (squash) March 2, 2026 17:49
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (805f4f0) to head (516f850).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #428   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          133       133           
  Lines         8649      8648    -1     
  Branches      1466      1466           
=========================================
- Hits          8649      8648    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9larsons 9larsons merged commit aaefbc8 into main Mar 2, 2026
3 of 4 checks passed
@9larsons 9larsons deleted the remove-json-stable-stringify branch March 2, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants