support video scale and different playback speed#94
Open
heartgoon2010 wants to merge 1 commit intomasterfrom
Open
support video scale and different playback speed#94heartgoon2010 wants to merge 1 commit intomasterfrom
heartgoon2010 wants to merge 1 commit intomasterfrom
Conversation
Member
allengotstuff
left a comment
allengotstuff
left a comment
There was a problem hiding this comment.
@heartgoon2010 Good job on those two featureS.
On a comment base, do we really need scale model? The video automatically adjust to the correctly aspect ratio, if we scale it up or down, it destroy the video aspect ratio.
However, on playback speed, i think it is a very good feature to have, and good choice to put in in UserController. Can you add some documentation on the method itself to indicated number's matching speed, for example 2.0f == speedX2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.