Conversation
…red non-issue/false-positives
…cript's module version
CGNonofr
reviewed
Mar 9, 2026
| "exports": { | ||
| ".": { | ||
| "types": "./lib/index.d.ts", | ||
| "import": "./lib/index.js", |
Collaborator
There was a problem hiding this comment.
Oh so that's the solution 🤔 I'm even more lost in those exports definitions...
Collaborator
Author
There was a problem hiding this comment.
Actually, default is just a safeguard, that always works. import should be sufficient in an esm only context.
Collaborator
Author
There was a problem hiding this comment.
Order is relevant, btw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a knip workspace configuration. I wanted to test the tool and it found some mismatching package definitions and unused exports. The larger the code base the more helpful this tool can be it seems.
I resolved most of the issues found and added ignores or non-issue/false-positives where applicable.
I need to add the entries for the package sub-exports.