Open
Conversation
Member
|
Great work so far! I have a couple changes I'd like to see:
|
Author
|
Currently, the colors can still change between each function call/different data sets. Is this the desired behavior, or should I make label colors persistent consistent throughout the entire program? |
Member
|
It'd be great if they were consistent throughout the whole program. |
Author
|
Commit 468cb4b is misnamed, that one is a large refactoring that changes spectrogram visualization to take a dataframe as input. |
Author
|
Once these changes are approved, I'll modify the tutorial notebook to properly call the new functions |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #135
These changes allow the
visualize_spectrogramfunction to graph multiple different categories, assigning each category a different label and color. All actual changes are done in thespectrogram_graphfunction, sincevisualize_spectrogramjust calls that to draw the final graph. If there are more than six categories, colors will start being re-used.Tested using a modified version of the Screaming Piha test dataset provided on here. Here are some results from different calls of the function, to make sure my changes matched the intended results:
spectrogram_visualization(clip_path, premade_annotations_df = manual_df[manual_df["IN FILE"] == "ScreamingPiha2.wav"],premade_annotations_label = "Piha Human Labels")spectrogram_visualization(clip_path,automated_df = True, isolation_parameters = isolation_parameters)spectrogram_visualization(clip_path,automated_df = True,isolation_parameters=isolation_parameters,premade_annotations_df = manual_df[manual_df["IN FILE"] == "ScreamingPiha2.wav"])