Javier/dma to flash #18

Byte-Entropy · 2026-01-29T04:36:57Z

MX66L1G45GMI: Add DMA-backed SPI interface and refactor driver

Add MX66L1G45GMI_Interface.cpp: DMA-based SPI interface implementation
Update MX66L1G45GMI.cpp/.hpp to support abstracted interface and DMA
Integrate DMATransfer.hpp for efficient SPI transfers
Refactor driver to use function pointers for SPI, CS, and delay
Improve blocking/wait logic for DMA safety

This commit adds the initial, complete C++ driver for the NAU7802 sensor, placing it in the PeripheralDriversSubmodule. - Includes a reusable I2C_Wrapper to abstract STM32 HAL functions. - Implements core logic: init, reset, setGain, and readSensor. - Adds register definitions, example usage files, and a README.

Renamed Files: Changed I2C_Wrapper source and header files to i2c_wrapper (lowercase) for consistent naming conventions. Driver Update: Updated NAU7802 constructor to accept the I2C wrapper pointer and HAL_Delay function directly. Main Test Update: Modified main_read_test.cpp to implement the new initialization logic, set default gain to 1x, and added placeholders for future calibration. Cleanup: Removed the redundant ExampleUsage.cpp and the binary datasheet file (.pdf). Registers: Minor updates to register definitions in NAU7802_regs.hpp.

- Add MX66L1G45GMI_Interface.cpp: DMA-based SPI interface implementation - Update MX66L1G45GMI.cpp/.hpp to support abstracted interface and DMA - Integrate DMATransfer.hpp for efficient SPI transfers - Refactor driver to use function pointers for SPI, CS, and delay - Improve blocking/wait logic for DMA safety

Copilot

Pull request overview

Adds a DMA-backed SPI interface layer for the MX66L1G45GMI flash driver and refactors the core driver to use injected function pointers for IO (SPI read/write, chip-select, delay), along with new usage documentation.

Changes:

Added a new interface implementation (MX66L1G45GMI_Interface.cpp) intended to bridge the abstract driver to STM32 SPI/DMA.
Refactored the core driver (MX66L1G45GMI.cpp/.hpp) to use an injected MX66_Config (function pointers) instead of direct HAL calls.
Added a new driver README and updated gitignore rules related to DMA notes / Makefile.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
MX66L1G45GMI/README.md	Documents the layered architecture and initialization/usage guidance for the new injected/DMA approach.
MX66L1G45GMI/MX66L1G45GMI_Interface.cpp	Provides the concrete STM32 HAL + DMA-based implementation of the injected IO hooks.
MX66L1G45GMI/MX66L1G45GMI.cpp	Refactors the driver internals to call injected function pointers for SPI/CS/delay.
MX66L1G45GMI/Inc/MX66L1G45GMI.hpp	Introduces the `MX66_Config` struct and `MX66_Init()` API for dependency injection.
DMA/.gitignore	Ignores local DMA notes file(s).
.gitignore	Adds an ignore rule for `Makefile`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

MX66L1G45GMI/MX66L1G45GMI.cpp

Copilot · 2026-01-31T17:43:33Z

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

+    // Use DMA Tool
+    DMAControl::Transfer(&hspi1, 0, nullptr, data, len);
+    // BLOCKING WAIT
+    while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);


Same issue as the write path: DMAControl::Transfer uses HAL_SPI_TransmitReceive_DMA(...) and will fail when txData is nullptr. For RX-only, the helper should call HAL_SPI_Receive_DMA (or provide a dummy TX buffer), and the returned status should be checked.

Suggested change

// Use DMA Tool

DMAControl::Transfer(&hspi1, 0, nullptr, data, len);

// BLOCKING WAIT

while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);

// For small reads, use polling to avoid DMA overhead

if (len <= 32) {

HAL_SPI_Receive(&hspi1, data, len, 100);

} else {

// Use DMA for larger reads

HAL_StatusTypeDef status = HAL_SPI_Receive_DMA(&hspi1, data);

if (status != HAL_OK) {

// DMA did not start; return without blocking indefinitely

return;

}

// BLOCKING WAIT

while (HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);

}

Copilot · 2026-01-31T17:43:33Z

MX66L1G45GMI/README.md

+
+- Template-based utility
+- Automated Cache Coherency (D-Cache cleaning/invalidating for G4/H7)
+- Protocol-specific DMA calls (`HAL_SPI_Transmit_DMA`, etc.)


The README claims the DMA tool uses protocol-specific calls like HAL_SPI_Transmit_DMA, but the current DMAControl::Transfer implementation uses HAL_SPI_TransmitReceive_DMA for SPI. Either update the documentation to match the implementation, or update the DMA helper to select Transmit_DMA / Receive_DMA / TransmitReceive_DMA based on which buffers are provided.

Suggested change

- Protocol-specific DMA calls (`HAL_SPI_Transmit_DMA`, etc.)

- Protocol-specific DMA calls (e.g., `HAL_SPI_TransmitReceive_DMA` for SPI)

Copilot · 2026-01-31T17:43:33Z

MX66L1G45GMI/MX66L1G45GMI.cpp

+void SPI_Write(uint8_t *data, uint16_t len) {
+    if(io_driver.Write) io_driver.Write(data, len);
+}


These wrapper functions become silent no-ops when MX66_Init() hasn’t been called (function pointers are null). That makes failures hard to diagnose and is a breaking behavior change vs the prior direct-HAL implementation. Consider providing default HAL-backed implementations in io_driver, or emitting a clear error/assert when the driver is used before initialization.

MX66L1G45GMI/MX66L1G45GMI.cpp

Copilot · 2026-01-31T17:43:34Z

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

+        HAL_SPI_Transmit(&hspi1, (uint8_t*)data, len, 100);
+    } else {
+        // Use DMA Tool for data
+        DMAControl::Transfer(&hspi1, 0, (uint8_t*)data, nullptr, len);


DMAControl::Transfer currently routes SPI to HAL_SPI_TransmitReceive_DMA(...), which returns HAL_ERROR if either TX or RX pointer is null. Here rxData is nullptr, so the DMA transfer will not run. Update the DMA helper to call HAL_SPI_Transmit_DMA for TX-only transfers (or provide a valid RX buffer), and check/handle the returned status.

Copilot · 2026-01-31T17:43:34Z

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

+        DMAControl::Transfer(&hspi1, 0, (uint8_t*)data, nullptr, len);
+
+        // BLOCKING WAIT: Protects the stack buffer 'tData' inside the driver
+        while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);


Unbounded busy-spin: while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY); can hang forever if the SPI enters an error state or the DMA never starts. Add a timeout and handle HAL_SPI_STATE_ERROR (and consider yielding/delaying in RTOS builds).

Copilot · 2026-01-31T17:43:34Z

MX66L1G45GMI/README.md

+- Connects the Abstract Driver to the actual STM32 hardware
+- Implements `IMPL_Write`, `IMPL_Read`, `IMPL_SetCS`, and `IMPL_Delay`
+- Uses a hybrid strategy: Polling for small commands (≤ 32 bytes) and DMA for large data payloads
+- note: Delay implementation on `MX66L1G45GMI_Interface.cpp` is subgect to change via


This bullet is incomplete (ends with "via") and contains a typo ("subgect" → "subject"). Clarify what mechanism is intended for changing the delay implementation (e.g., "...is subject to change via editing IMPL_Delay").

Suggested change

- note: Delay implementation on `MX66L1G45GMI_Interface.cpp` is subgect to change via

- Note: Delay implementation in `MX66L1G45GMI_Interface.cpp` is subject to change via editing `IMPL_Delay` below.

Copilot · 2026-01-31T17:43:34Z

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

+    // Use DMA Tool
+    DMAControl::Transfer(&hspi1, 0, nullptr, data, len);
+    // BLOCKING WAIT
+    while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);


Unbounded busy-spin: while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY); can hang forever if the SPI enters an error state or the DMA never starts. Add a timeout and handle HAL_SPI_STATE_ERROR (and consider yielding/delaying in RTOS builds).

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

…ralDriversSubmodule into Javier/DmaToFlash

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

Copilot · 2026-01-31T18:30:53Z

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

+    // Use DMA Tool
+    DMAControl::Transfer(&hspi1, 0, nullptr, data, len);
+    // BLOCKING WAIT
+    for (int TIMEOUT = 1000000; TIMEOUT > 0; TIMEOUT--) {
+        if(HAL_SPI_GetState(&hspi1) == HAL_SPI_STATE_READY) break;
+        MX66_Delay(1);
+    }
+
+    }
+
+    //while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);
+
+
+    /*
+    Unbounded busy-spin: while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY); can hang 
+    forever if the SPI enters an error state or the DMA never starts. Add a timeout and handle HAL_SPI_STATE_ERROR
+     (and consider yielding/delaying in RTOS builds).
+    */


IMPL_Read calls DMAControl::Transfer(&hspi1, ..., nullptr, data, len). DMAControl::Transfer for SPI uses HAL_SPI_TransmitReceive_DMA (DMA/DMATransfer.hpp:39), which expects a valid TX buffer; txData=nullptr will fail and no clocks will be generated for SPI reads. Use HAL_SPI_Receive_DMA (or update DMAControl::Transfer to use Receive_DMA when txData==nullptr), or pass a dummy TX buffer filled with 0xFF/0x00.

Suggested change

// Use DMA Tool

DMAControl::Transfer(&hspi1, 0, nullptr, data, len);

// BLOCKING WAIT

for (int TIMEOUT = 1000000; TIMEOUT > 0; TIMEOUT--) {

if(HAL_SPI_GetState(&hspi1) == HAL_SPI_STATE_READY) break;

MX66_Delay(1);

}

}

//while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);

/*

Unbounded busy-spin: while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY); can hang

forever if the SPI enters an error state or the DMA never starts. Add a timeout and handle HAL_SPI_STATE_ERROR

(and consider yielding/delaying in RTOS builds).

*/

// Start SPI receive using DMA

if (HAL_SPI_Receive_DMA(&hspi1, data, len) != HAL_OK) {

// Optional: handle error (e.g., logging) if needed

return;

}

// BLOCKING WAIT with timeout to avoid unbounded busy-spin

for (int TIMEOUT = 1000000; TIMEOUT > 0; TIMEOUT--) {

if (HAL_SPI_GetState(&hspi1) == HAL_SPI_STATE_READY) {

break;

}

MX66_Delay(1);

}

Copilot · 2026-01-31T18:30:53Z

MX66L1G45GMI/README.md

+// Delay Implementation
+void IMPL_Delay(uint32_t ms) {
+    // Change this line to switch between HAL_Delay, osDelay, vTaskDelay, etc
+    osDelay(ms); 


README’s IMPL_Delay example uses osDelay(ms), but the current MX66L1G45GMI_Interface.cpp implementation uses HAL_Delay(ms). Update the README snippet (or the code) so the documented default matches the actual implementation.

Suggested change

osDelay(ms);

HAL_Delay(ms);

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

Byte-Entropy added 10 commits October 25, 2025 11:14

Updated Readme to match previous Refactor

abdf0f2

WIP Task.cpp

1211490

d59885a

WIP: Implement Custom Delay

b26641e

Fix: Driverr compilation (obj) Success

839aa90

Initial Commit ADD DMA Transfer SPI & I2C

dabe891

Modif rm txt

147c7d7

Byte-Entropy requested a review from AndreyDiDev January 29, 2026 04:36

Byte-Entropy self-assigned this Jan 29, 2026

Byte-Entropy and others added 2 commits January 31, 2026 09:42

ADD Comprehensive README

6d49ad3

Merge branch 'master' into Javier/DmaToFlash

db2a532

Byte-Entropy requested a review from Copilot January 31, 2026 17:33

Copilot started reviewing on behalf of Byte-Entropy January 31, 2026 17:33 View session

Copilot AI reviewed Jan 31, 2026

View reviewed changes

Byte-Entropy added 2 commits January 31, 2026 11:17

FIX problems under Git Comments

7c9a2b6

Merge branch 'Javier/DmaToFlash' of https://github.com/UCSOAR/Periphe…

41dcf52

…ralDriversSubmodule into Javier/DmaToFlash

Byte-Entropy requested a review from Copilot January 31, 2026 18:23

Copilot started reviewing on behalf of Byte-Entropy January 31, 2026 18:24 View session

Copilot AI reviewed Jan 31, 2026

View reviewed changes

-    // Use DMA Tool
-    DMAControl::Transfer(&hspi1, 0, nullptr, data, len);
-    // BLOCKING WAIT
-    while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);
+    // For small reads, use polling to avoid DMA overhead
+    if (len <= 32) {
+        HAL_SPI_Receive(&hspi1, data, len, 100);
+    } else {
+        // Use DMA for larger reads
+        HAL_StatusTypeDef status = HAL_SPI_Receive_DMA(&hspi1, data);
+        if (status != HAL_OK) {
+            // DMA did not start; return without blocking indefinitely
+            return;
+        }
+        // BLOCKING WAIT
+        while (HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);
+    }

	- Protocol-specific DMA calls (`HAL_SPI_Transmit_DMA`, etc.)
	- Protocol-specific DMA calls (e.g., `HAL_SPI_TransmitReceive_DMA` for SPI)

	- note: Delay implementation on `MX66L1G45GMI_Interface.cpp` is subgect to change via
	- Note: Delay implementation in `MX66L1G45GMI_Interface.cpp` is subject to change via editing `IMPL_Delay` below.

Javier/dma to flash #18

Are you sure you want to change the base?

Javier/dma to flash #18

Conversation

Byte-Entropy commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants