Skip to content

Adamg/airbrakestask#3

Open
b-atteryacid wants to merge 2 commits into
masterfrom
adamg/airbrakestask
Open

Adamg/airbrakestask#3
b-atteryacid wants to merge 2 commits into
masterfrom
adamg/airbrakestask

Conversation

@b-atteryacid
Copy link
Copy Markdown
Contributor

Airbrakes task and CANBUS integration with airbrakes task

@shivamdesai04
Copy link
Copy Markdown
Member

Sorry, commenting in file is not working right now. lets see if this works

  1. Airbrakes_COMMAND_ENABLE. Change enable and disbale to open and close
  2. This is open loop control right? If so we should always store the last known position for the airbrakes in case of a power reset.
  3. What is airbrakesDriver.Adjust();. The name is vague, so its not clear what the API does. Can we pls change that
  4. Same enum all caps comment as camera PR
  5. Where do we set the open and close positions?
  6. Do you expect to do it with airbrakesDriver.SetTargetLevel(lvl); . It only takes in one int as the parameter. we should set open and close levels at initialization
  7. What is the purpose of the RPB_FROM_DAQ_AIR_BRAKES_LEVEL command

AndreyDiDev pushed a commit to UCSOAR/PeripheralDriversSubmodule that referenced this pull request May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants