refactor(ui5-table): use generics for table cell types #12771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12771--ui5-webcomponents.netlify.app |
aborjinik
requested review from
DonkeyCo and
simlin
and removed request for
DonkeyCo
nnaydenow
approved these changes
Dec 9, 2025
aborjinik
force-pushed
the
ui5-table-refactoring
branch
from
5d1f87d to
25d2962
Compare
- Background of the growing button is also set Fixes: #12765
aborjinik
force-pushed
the
ui5-table-refactoring
branch
from
25d2962 to
baa468d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableHeaderRow and TableRow uses cells slot with different types(TableHeaderCell/TableCell)
TableRowBase deals with cells both for TableHeaderRow and TableRow
Not to cast everytime when the corresponding cells are accessed we now use generics
Background of the growing button is also set
Fixes: [ui5-table]: growing button doesn't have correct color #12765