Merge upstream unstable changes#12
Open
mishaturnbull wants to merge 5680 commits into
Open
Conversation
We don't do a good job of modelling body tubes with some sort of opening to the front. This comes up with things like booster sections post-separation; whatever is used for an interstage will typically have an open forward airframe. It might be interesting to try to model this, but questions of how to account for how deep the recess is at the front would need to be resolved. Maybe someday, not today. Note that in the special case of a tube fin, which is simply an open cylinder with no internal structure, we do try to model it. But that's not a body tube or other closed symmetric component. So, at launch and at stage separation time we check for an open forward airframe and flag an info-level warning to let the user know about it. However, the vast majority of users don't care about simulating a booster post-separation and don't seem to understand that their boosters do in fact have an open forward airframe, so the warning unnecessarily alarms them and we get questions about it. Also, there are many situations where the rocket has much bigger issues and telling them about the open airframe is distracting. As a result, with this commit we have two sets of heuristics used to filter out the warning. 1) Does the user care? Within BarrowmanStabilityCalculator, we set the warning if we're analyzing the sustainer (if the user doesn't care what the sustainer does, why are the simulating?), and if the booster has a recovery device -- we're taking this as an indication the user cares what the booster does post-separation. What this turns into is we only set the warning on booster stages with a recovery device. 2) Does the user have bigger fish to fry? Here, if the stage (which could be the sustainer or the booster) is unstable it really doesn't matter what the sim says about performance. Also, if either a recovery device has already deployed or is going to deploy within the next half second, it doesn't really matter -- in this case, the user should be much more concerned with their chute shredding! Since this depends on the current simulation status, this filtering happens in BasicEventSimulationEngine.
This avoids string-concatenated SQL (eliminating the SpotBugs SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE warning) and is consistent with the short, imperative style used in this repo.
Further refinement of open airframe warning filters.
Sync translations from Crowdin
Useful for when we want to implement #2263
# Conflicts: # swing/src/main/java/info/openrocket/swing/gui/simulation/SimulationOptionsPanel.java
[#3120] Fix motor designation and common name handling
Sync translations from Crowdin
Translate messages_zh.properties to Chinese
Improve sim window size
Reduce profiler hotspots in simulation status, component transforms, and structure mass calculation
Sync translations from Crowdin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges a few changes from the upstream repo. Hopefully will have some effect on issue #9.