Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,25 @@ RUN mkdir /download && \
tar xzf apache-tomcat-*tar.gz && \
mv apache-tomcat-9.0.112 /usr/local/tomcat/ && \
cd / && \
rm -rf /download && \
rm -rf /usr/local/tomcat/webapps/* && \
mkdir /usr/local/tomcat/webapps/ROOT && \
echo "<html><body>Nothing to see here</body></html>" > /usr/local/tomcat/webapps/ROOT/index.html
echo "<html><body>Nothing to see here</body></html>" > /usr/local/tomcat/webapps/ROOT/index.html && \
mkdir -p /usr/local/tomecat/conf/Catalina/localhost
# Now replace the Tomcat logging with logback
# NOTE: I have review this method in jd-gui and do not see anything malicious, packages are isolated to avoid issues
# with other code.
# Additionally, when we are not also accounting for some legacy systems, we will likely shift to
# Jetty to simplify the deployment process, making this subtitution unnecessary.
RUN cd /download && \
wget https://repo1.maven.org/maven2/com/github/tomcat-slf4j-logback/tomcat9-slf4j-logback/9.0.115/tomcat9-slf4j-logback-9.0.115.jar && \
echo "cb463fb246fbb326d91b04a7280474f2b722b11cc9d3d7f6c3dbbefcff2c07e055f479d436ab785668d6fa90d0bfd325c86c4fa3a9ad9521159a2a3114916d91 *tomcat9-slf4j-logback-9.0.115.jar" > checksum.logback.txt && \
sha512sum -c checksum.logback.txt
RUN cd /download && \
cp tomcat9-slf4j-logback-9.0.115.jar /usr/local/tomcat/bin/tomcat-juli.jar && \
rm /usr/local/tomcat/conf/logging.properties && \
rm -rf /download


CMD ["/usr/local/tomcat/bin/catalina.sh","run"]

FROM tomcat_base AS api
Expand All @@ -43,6 +58,9 @@ COPY --from=builder /builddir/cwms-data-api/build/docker/context.xml /usr/local/
COPY --from=builder /builddir/cwms-data-api/build/docker/server.xml /usr/local/tomcat/conf
COPY --from=builder /builddir/cwms-data-api/build/docker/setenv.sh /usr/local/tomcat/bin
COPY --from=builder /builddir/cwms-data-api/build/docker/libs/ /usr/local/tomcat/lib
COPY --from=builder /builddir/cwms-data-api/build/docker/logback.xml /logback.xml
COPY --from=builder /builddir/cwms-data-api/build/docker/logback-juli.xml /logback-juli.xml
COPY --from=builder /builddir/cwms-data-api/build/docker/app-context.xml /usr/local/tomcat/conf/Catalina/localhost/cwms-data.xml

ENV CDA_JDBC_DRIVER="oracle.jdbc.driver.OracleDriver"
ENV CDA_JDBC_URL=""
Expand Down
16 changes: 15 additions & 1 deletion cda-gui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 22 additions & 8 deletions cwms-data-api/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,15 @@ configurations {
}

configurations.implementation {
exclude group: 'com.oracle.database.jdbc'
exclude group: 'com.oracle.database.jdbc'
}

configurations.all {
exclude group: 'dom4j'
exclude group: 'org.apache.xmlbeans'
exclude group: 'org.apache.poi'
exclude group: 'org.bouncycastle'
exclude group: 'org.apache.tomcat', module: 'tomcat-juli'
}

dependencies {
Expand Down Expand Up @@ -64,7 +65,7 @@ dependencies {
}
implementation(files("$buildDir/libs/${project.name}-${project.version}-codegen-shadow.jar"))

implementation(libs.slf4j)
compileOnly(libs.slf4j)

implementation(libs.monolith) {
//exclude group: "org.python", module: "jython-standalone"
Expand All @@ -75,7 +76,8 @@ dependencies {
implementation(libs.google.flogger.api)
implementation(libs.google.findbugs)
implementation(libs.google.errorProne)
runtimeOnly(libs.google.flogger.backend)
implementation(project(":flogger-cda-context"))
runtimeOnly(libs.google.flogger.system.backend)

implementation(libs.nucleus.data) {
exclude group: "org.jdom"
Expand Down Expand Up @@ -153,16 +155,22 @@ dependencies {

tomcatLibs(libs.bundles.tomcat.embedded)
tomcatLibs(libs.bundles.tomcat.support)

implementation(libs.slf4j)
testImplementation(libs.slf4j.jul)
tomcatLibs(libs.google.flogger.api)
tomcatLibs(libs.google.flogger.backend)
tomcatLibs(libs.google.flogger.system.backend)
baseLibs(libs.google.flogger.slf4j.backend) {
exclude group: "org.slf4j"
}

baseLibs(libs.ch.qos.logback)

testImplementation(libs.bundles.testcontainers)

testImplementation(libs.apache.commons.csv)
testImplementation(libs.cwms.tomcat.auth)
testImplementation(libs.apache.freemarker)

testRuntimeOnly("org.slf4j:slf4j-jdk14:2.0.16")
testImplementation(libs.apache.freemarker)

webjars(project(":cda-gui"))

Expand All @@ -186,7 +194,10 @@ task extractWebJars(type: Copy) {
war {
dependsOn extractWebJars
from "$buildDir/extra"
from "src/resources/"
from "src/resources/"
// classpath = classpath.filter { file ->
// !file.name.contains("slf4j-api")
// }

manifest {
attributes "build-version": project.version
Expand Down Expand Up @@ -256,6 +267,7 @@ task run(type: JavaExec) {
args "$buildDir/tomcat", "$buildDir/libs/${project.name}-${project.version}.war", context
jvmArgs += "-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager"
jvmArgs += "-Djava.util.logging.config.file=$projectDir/logging.properties"
jvmArgs += "-Dlogback.configurationFile=${projectDir}/logback.xml"
jvmArgs += "-DTOMCAT_RESOURCES=$buildDir/tomcat/conf/context.xml"
jvmArgs += "-Dorg.apache.tomcat.util.digester.PROPERTY_SOURCE=org.apache.tomcat.util.digester.EnvironmentPropertySource"
jvmArgs += "-Dcatalina.base=$buildDir/tomcat"
Expand Down Expand Up @@ -285,6 +297,7 @@ task integrationTests(type: Test) {
jvmArgs += "-DwarContext=/cwms-data"
jvmArgs += "-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager"
jvmArgs += "-Djava.util.logging.config.file=$projectDir/logging.properties"
jvmArgs += "-Dlogback.configurationFile=${projectDir}/logback.xml"
jvmArgs += "-Dorg.apache.tomcat.util.digester.PROPERTY_SOURCE=org.apache.tomcat.util.digester.EnvironmentPropertySource"
jvmArgs += "-Dcwms.dataapi.access.provider=MultipleAccessManager"
jvmArgs += "-Dcwms.dataapi.access.providers=KeyAccessManager,CwmsAccessManager"
Expand All @@ -302,6 +315,7 @@ task prepareDockerBuild(type: Copy, dependsOn: war) {

from(configurations.baseLibs) {
into "libs"
//exclude "**/logback*"
}

from(sourceSets.test.resources) {
Expand Down
29 changes: 29 additions & 0 deletions cwms-data-api/logback.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?xml version="1.0" encoding="UTF-8" ?>
<!DOCTYPE configuration>
<configuration>
<import class="ch.qos.logback.classic.encoder.JsonEncoder"/>
<import class="ch.qos.logback.core.ConsoleAppender"/>
<import class="ch.qos.logback.core.FileAppender"/>
<variable name="LOG_LEVEL" value="${LOG_LEVEL:-FINE}"/>
<contextName>CWMS-Data-API</contextName>
<appender name="STDERR" class="ConsoleAppender">
<encoder class="JsonEncoder"/>
<target>System.err</target>
</appender>

<appender name="FILE" class="FileAppender">
<encoder class="JsonEncoder"/>
<append>false</append>
<immediateFlush>true</immediateFlush>
<file>build/cda.log</file>
</appender>

<logger name="cwms.cda" level="${LOG_LEVEL}"/>
<logger name="fixtures" level="${LOG_LEVEL}"/>
<logger name="org.apache" level="ERROR"/>

<root level="INFO">
<appender-ref ref="STDERR"/>
<appender-ref ref="FILE"/>
</root>
</configuration>
8 changes: 8 additions & 0 deletions cwms-data-api/src/docker/app-context.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<Context antiResourceLocking="true" delegate="true">
<ResourceLink
name="jdbc/CWMS3"
global="jdbc/CWMS3"
type="javax.sql.DataSource"
/>
</Context>
29 changes: 29 additions & 0 deletions cwms-data-api/src/docker/logback-juli.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?xml version="1.0" encoding="UTF-8" ?>
<!DOCTYPE configuration>
<configuration debug="true">
<import class="org.apache.juli.logging.ch.qos.logback.classic.encoder.JsonEncoder"/>
<import class="org.apache.juli.logging.ch.qos.logback.core.ConsoleAppender"/>

<variable name="LOG_LEVEL" value="${LOG_LEVEL:-INFO}"/>
<contextName>CWMS-Data-API</contextName>
<appender name="STDERR" class="ConsoleAppender">
<encoder class="JsonEncoder"/>
<target>System.err</target>
</appender>

<logger name="cwms.cda" level="${LOG_LEVEL}"/>
<logger name="org.apache" level="ERROR"/>

<logger name="org.apache.catalina" level="INFO" additivity="false">
<appender-ref ref="STDERR" />
</logger>

<logger name="org.apache.catalina.core.ContainerBase.[Catalina]" level="INFO" additivity="false">
<appender-ref ref="STDERR" />
</logger>


<root level="INFO">
<appender-ref ref="STDERR"/>
</root>
</configuration>
29 changes: 29 additions & 0 deletions cwms-data-api/src/docker/logback.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?xml version="1.0" encoding="UTF-8" ?>
<!DOCTYPE configuration>
<configuration debug="true">
<import class="ch.qos.logback.classic.encoder.JsonEncoder"/>
<import class="ch.qos.logback.core.ConsoleAppender"/>

<variable name="LOG_LEVEL" value="${LOG_LEVEL:-INFO}"/>
<contextName>CWMS-Data-API</contextName>
<appender name="STDERR" class="ConsoleAppender">
<encoder class="JsonEncoder"/>
<target>System.err</target>
</appender>

<logger name="cwms.cda" level="${LOG_LEVEL}"/>
<logger name="org.apache" level="ERROR"/>

<logger name="org.apache.catalina" level="INFO" additivity="false">
<appender-ref ref="STDERR" />
</logger>

<logger name="org.apache.catalina.core.ContainerBase.[Catalina]" level="INFO" additivity="false">
<appender-ref ref="STDERR" />
</logger>


<root level="INFO">
<appender-ref ref="STDERR"/>
</root>
</configuration>
6 changes: 5 additions & 1 deletion cwms-data-api/src/docker/setenv.sh
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
export CATALINA_OPTS="$CATALINA_OPTS -Dorg.apache.tomcat.util.digester.PROPERTY_SOURCE=org.apache.tomcat.util.digester.EnvironmentPropertySource"
CATALINA_OPTS="$CATALINA_OPTS -Dorg.apache.tomcat.util.digester.PROPERTY_SOURCE=org.apache.tomcat.util.digester.EnvironmentPropertySource"
CATALINA_OPTS="$CATALINA_OPTS -Djuli-logback.configurationFile=/logback-juli.xml -Djuli-logback.ContextSelector=JNDI"
CATALINA_OPTS="$CATALINA_OPTS -Dlogback.configurationFile=/logback.xml -Dlogback.ContextSelector=JNDI"

export CATALINA_OPTS
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@
import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
import com.google.common.flogger.FluentLogger;
import com.google.common.flogger.context.ScopedLoggingContexts;

import java.util.stream.Collectors;
import java.util.stream.Stream;

Expand Down Expand Up @@ -190,9 +192,12 @@ public Map<RatingSpec, Set<AbstractRatingMetadata>> getRatingsForIds(
boolean useParallel = true;
Stream<Map<RatingSpec, Set<AbstractRatingMetadata>>> mapStream;
if (useParallel) {
// get current context to pass in to Thread. Otherwise any log message would not include the Trace ID.
final var loggingContext = ScopedLoggingContexts.newContext();
mapStream = ratingIds.stream()
.map(ratingId -> CompletableFuture.supplyAsync(() ->
retrieveRatings(office, ratingId, start, end), executor))
loggingContext.callUnchecked(() -> retrieveRatings(office, ratingId, start, end))
, executor))
.collect(Collectors.toList())
.stream()
.map(CompletableFuture::join);
Expand Down Expand Up @@ -221,7 +226,6 @@ public Map<RatingSpec, Set<AbstractRatingMetadata>> getRatingsForIds(
public Map<RatingSpec, Set<AbstractRatingMetadata>> retrieveRatings(
String office, String templateIdMask, ZonedDateTime start, ZonedDateTime end) {
Map<RatingSpec,Set<AbstractRatingMetadata>> retVal = new LinkedHashMap<>();

try (final Timer.Context ignored = markAndTime("retrieveRatings")) {
RatingSpecDao ratingSpecDao = new RatingSpecDao(dsl);
Optional<RatingSpec> spec = ratingSpecDao.retrieveRatingSpec(office, templateIdMask);
Expand Down
Loading
Loading