Skip to content

feat(apollo-vertex): add resolvedTheme and disableTransitionOnChange to ThemeProvider#410

Merged
KokoMilev merged 1 commit intomainfrom
shell-theme
Apr 1, 2026
Merged

feat(apollo-vertex): add resolvedTheme and disableTransitionOnChange to ThemeProvider#410
KokoMilev merged 1 commit intomainfrom
shell-theme

Conversation

@creilly11235
Copy link
Copy Markdown
Collaborator

Summary

  • Add resolvedTheme to theme context so consumers can read the actual "light" | "dark" value (needed when theme is "system")
  • Add disableTransitionOnChange prop to prevent CSS transition flash during theme switches (uses <style> injection matching the next-themes approach)
  • Add defaultTheme prop to allow overriding the default "system" fallback
  • Memoize context value with useMemo + useCallback to prevent unnecessary re-renders

🤖 Generated with Claude Code

@creilly11235 creilly11235 requested a review from a team as a code owner March 27, 2026 02:15
@creilly11235 creilly11235 requested review from KokoMilev and alincadariu and removed request for a team March 27, 2026 02:15
@KokoMilev KokoMilev enabled auto-merge (rebase) March 27, 2026 02:15
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-canvas 🟢 Ready Preview, Logs Apr 01, 2026, 05:13:33 AM
apollo-landing 🟢 Ready Preview, Logs Apr 01, 2026, 05:11:54 AM
apollo-ui-react 🟢 Ready Preview, Logs Apr 01, 2026, 05:12:34 AM
apollo-vertex 🟢 Ready Preview, Logs Apr 01, 2026, 05:13:07 AM
apollo-wind 🟢 Ready Preview, Logs Apr 01, 2026, 05:11:54 AM

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Dependency License Review

  • 1924 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 3 package(s) excluded (see details below)
License distribution
License Packages
MIT 1689
ISC 89
Apache-2.0 56
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 5
MIT OR Apache-2.0 3
MIT-0 3
CC0-1.0 3
LGPL-3.0-or-later 2
(MIT OR Apache-2.0) 2
Unlicense 2
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
@img/sharp-libvips-linuxmusl-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@github-actions github-actions bot added the size:M 30-99 changed lines. label Mar 31, 2026
@KokoMilev KokoMilev force-pushed the shell-theme branch 2 times, most recently from 19f5bed to ae520f5 Compare April 1, 2026 09:42
…to ThemeProvider

Upstream improvements from vertical-medical-mrs shell-theme-provider:
- resolvedTheme in context so consumers can read the actual light/dark value
- disableTransitionOnChange prop to prevent CSS transition flash on theme switch
- defaultTheme prop to allow overriding the default "system" fallback
- Memoized context value to prevent unnecessary re-renders

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@KokoMilev KokoMilev merged commit 1e336cf into main Apr 1, 2026
46 checks passed
@KokoMilev KokoMilev deleted the shell-theme branch April 1, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants