Skip to content

chore(apollo-vertex): enable type-aware linting in oxlint [AGVSOL-1969]#421

Open
KokoMilev wants to merge 4 commits intomainfrom
fix/apollo-vertex-type-aware-linting
Open

chore(apollo-vertex): enable type-aware linting in oxlint [AGVSOL-1969]#421
KokoMilev wants to merge 4 commits intomainfrom
fix/apollo-vertex-type-aware-linting

Conversation

@KokoMilev
Copy link
Copy Markdown
Contributor

@KokoMilev KokoMilev commented Mar 30, 2026

Add --type-aware flag to lint and lint:fix scripts so oxlint enforces type-checked rules that were fixed in PR #400.

Also fix deadlock caused by awaiting invalidateQueries in ensureValidToken.

@KokoMilev KokoMilev requested a review from a team as a code owner March 30, 2026 14:14
@KokoMilev KokoMilev requested review from VKravchuk, alincadariu and Copilot and removed request for a team March 30, 2026 14:14
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-canvas 🟢 Ready Preview, Logs Mar 31, 2026, 08:16:20 AM
apollo-landing 🟢 Ready Preview, Logs Mar 31, 2026, 08:13:11 AM
apollo-ui-react 🟢 Ready Preview, Logs Mar 31, 2026, 08:15:14 AM
apollo-vertex 🟢 Ready Preview, Logs Mar 31, 2026, 08:14:37 AM
apollo-wind 🟢 Ready Preview, Logs Mar 31, 2026, 08:13:26 AM

@KokoMilev KokoMilev enabled auto-merge (rebase) March 30, 2026 14:14
@github-actions github-actions bot added the size:XS 0-9 changed lines. label Mar 30, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026 •
edited
Loading

Dependency License Review

  • ✅ 1926 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 3 package(s) excluded (see details below)
License distribution
License Packages
MIT 1691
ISC 89
Apache-2.0 56
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 5
MIT OR Apache-2.0 3
MIT-0 3
CC0-1.0 3
LGPL-3.0-or-later 2
(MIT OR Apache-2.0) 2
Unlicense 2
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
@img/sharp-libvips-linuxmusl-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copilot AI reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Apollo Vertex app tooling to run Oxlint with type-aware rules, and adjusts the OAuth callback token flow to avoid a React Query deadlock during query invalidation.

Changes:

  • Enable oxlint --type-aware for lint and lint:fix scripts in apps/apollo-vertex.
  • Avoid awaiting queryClient.invalidateQueries inside ensureValidToken after handling the OAuth callback to prevent a deadlock.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/apollo-vertex/package.json Turns on type-aware linting for the Vertex app’s lint scripts.
apps/apollo-vertex/lib/auth.ts Changes token query invalidation to be non-blocking after OAuth callback completion.

@KokoMilev KokoMilev force-pushed the fix/apollo-vertex-type-aware-linting branch from 6b4f317 to 67bd346 Compare March 30, 2026 14:39
@github-actions github-actions bot added size:M 30-99 changed lines. and removed size:XS 0-9 changed lines. labels Mar 30, 2026
Copilot AI review requested due to automatic review settings March 30, 2026 14:45
@KokoMilev KokoMilev force-pushed the fix/apollo-vertex-type-aware-linting branch from 67bd346 to 07f8be0 Compare March 30, 2026 14:45
@github-actions github-actions bot added size:L 100-499 changed lines. and removed size:M 30-99 changed lines. labels Mar 30, 2026
Copilot AI reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@KokoMilev KokoMilev force-pushed the fix/apollo-vertex-type-aware-linting branch from 5e52431 to 2525e8f Compare March 31, 2026 10:38
Copilot AI review requested due to automatic review settings March 31, 2026 10:38
Copilot AI reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@KokoMilev KokoMilev force-pushed the fix/apollo-vertex-type-aware-linting branch from 2525e8f to f257912 Compare March 31, 2026 11:08
Copilot AI review requested due to automatic review settings March 31, 2026 11:51
@KokoMilev KokoMilev force-pushed the fix/apollo-vertex-type-aware-linting branch from f257912 to 94a7e67 Compare March 31, 2026 11:51
Copilot AI reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@KokoMilev
chore(apollo-vertex): enable type-aware linting in oxlint [AGVSOL-1969]
12864d5 
Add --type-aware flag to lint and lint:fix scripts so oxlint enforces
type-checked rules that were fixed in PR #400.
Add oxlint-tsgolint dependency required for type-aware mode.
Fix deadlock in ensureValidToken by replacing await with void on invalidateQueries.
@KokoMilev
fix(apollo-vertex): improve token parsing error handling in ensureVal…
ac85ae9 
…idToken
@KokoMilev
fix(apollo-vertex): resolve type-aware lint errors in data-table comp…
459bc19 
…onents

- Type onGlobalFilterChange callback with Updater<string> (no-unsafe-argument)
- Narrow cell value with typeof checks instead of String() cast (no-base-to-string)
- Suppress no-unsafe-assignment at tanstack getFilterValue() boundary
Copilot AI review requested due to automatic review settings March 31, 2026 15:00
@KokoMilev KokoMilev force-pushed the fix/apollo-vertex-type-aware-linting branch from 2404c5d to 459bc19 Compare March 31, 2026 15:00
Copilot AI reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@VKravchuk VKravchuk Awaiting requested review from VKravchuk VKravchuk is a code owner automatically assigned from UiPath/team-frontendhoven

@alincadariu alincadariu Awaiting requested review from alincadariu alincadariu is a code owner automatically assigned from UiPath/team-frontendhoven

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size:L 100-499 changed lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KokoMilev