Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
This PR addresses TypeScript type-checking issues in the Apollo Vertex app by tightening a literal type in an ai-chat tool example and adding a dedicated typecheck script to the app’s package scripts.
Changes:
- Ensure the
presentChoicestool output preserves the"choices"string literal type. - Add a
typecheckscript (tsc --noEmit) toapps/apollo-vertex.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/apollo-vertex/registry/ai-chat/examples/choices-tool.ts | Preserves the "choices" literal type in the tool output to satisfy TypeScript. |
| apps/apollo-vertex/package.json | Adds a typecheck script for running TypeScript checks in the Vertex app. |
VKravchuk
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.