Skip to content

Fix/vertex type check [AGVSOL-2051]#443

Merged
KokoMilev merged 2 commits intomainfrom
fix/vertex-type-check
Apr 2, 2026
Merged

Fix/vertex type check [AGVSOL-2051]#443
KokoMilev merged 2 commits intomainfrom
fix/vertex-type-check

Conversation

@pieman1313
Copy link
Copy Markdown
Contributor

No description provided.

@pieman1313 pieman1313 requested a review from a team as a code owner April 2, 2026 06:36
@pieman1313 pieman1313 requested review from 0xr3ngar, angeloaltamiranom and Copilot and removed request for a team April 2, 2026 06:36
@KokoMilev KokoMilev enabled auto-merge (rebase) April 2, 2026 06:37
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-canvas 🟢 Ready Preview, Logs Apr 01, 2026, 11:40:43 PM
apollo-landing 🟢 Ready Preview, Logs Apr 01, 2026, 11:38:06 PM
apollo-ui-react 🟢 Ready Preview, Logs Apr 01, 2026, 11:39:53 PM
apollo-vertex 🟢 Ready Preview, Logs Apr 01, 2026, 11:39:25 PM
apollo-wind 🟢 Ready Preview, Logs Apr 01, 2026, 11:38:56 PM

@pieman1313 pieman1313 requested review from a team, VKravchuk and alincadariu April 2, 2026 06:37
@github-actions github-actions bot added the size:XS 0-9 changed lines. label Apr 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Dependency License Review

  • 1924 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 3 package(s) excluded (see details below)
License distribution
License Packages
MIT 1689
ISC 89
Apache-2.0 56
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 5
MIT OR Apache-2.0 3
MIT-0 3
CC0-1.0 3
LGPL-3.0-or-later 2
(MIT OR Apache-2.0) 2
Unlicense 2
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
@img/sharp-libvips-linuxmusl-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses TypeScript type-checking issues in the Apollo Vertex app by tightening a literal type in an ai-chat tool example and adding a dedicated typecheck script to the app’s package scripts.

Changes:

  • Ensure the presentChoices tool output preserves the "choices" string literal type.
  • Add a typecheck script (tsc --noEmit) to apps/apollo-vertex.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/apollo-vertex/registry/ai-chat/examples/choices-tool.ts Preserves the "choices" literal type in the tool output to satisfy TypeScript.
apps/apollo-vertex/package.json Adds a typecheck script for running TypeScript checks in the Vertex app.

@KokoMilev KokoMilev merged commit 89599b6 into main Apr 2, 2026
45 checks passed
@KokoMilev KokoMilev deleted the fix/vertex-type-check branch April 2, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants