fix(apollo-react): add data-test id for case E2E#444
Open
SreedharAvvari wants to merge 1 commit intomainfrom
Open
fix(apollo-react): add data-test id for case E2E#444SreedharAvvari wants to merge 1 commit intomainfrom
SreedharAvvari wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds an explicit data-testid hook to the Stage node header to support E2E targeting, and covers it with a unit test in apollo-react’s canvas components.
Changes:
- Add
data-testid="stage-header-${id}"to theStageHeaderelement inStageNode. - Add a unit test asserting the header test id is rendered as expected.
- Minor import reordering/cleanup in
StageNodeand its test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/apollo-react/src/canvas/components/StageNode/StageNode.tsx | Adds data-testid to the stage header element (keyed by node id) for E2E selection. |
| packages/apollo-react/src/canvas/components/StageNode/StageNode.test.tsx | Adds a test verifying the stage header data-testid is present and stable for the default id. |
Dependency License Review
License distribution
Excluded packages
|
SreedharAvvari
force-pushed
the
chore/add-data-testid
branch
from
3f6f688 to
526976c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.