feat(apollo-react): add stage and task status tooltip [MST-10211]#751
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
Adds localized execution-status labels for Stage/Task icons (used for tooltip text + aria-label), localizes Sticky Note toolbar actions, and improves Storybook locale switching by driving ApI18nProvider via <html lang>.
Changes:
- Introduces
useExecutionStatusLabel()to map stage/task execution statuses to localized, human-readable labels and uses it inStageNodeHeaderandTaskContent. - Localizes missing Sticky Note toolbar strings and adds corresponding English catalog entries.
- Adds a Storybook locale toolbar that updates
<html lang>and remounts stories to re-run locale detection.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/apollo-react/src/canvas/locales/en.json | Adds English strings for stage/task statuses and Sticky Note toolbar actions. |
| packages/apollo-react/src/canvas/components/StickyNoteNode/StickyNoteNode.tsx | Replaces hardcoded toolbar labels with useSafeLingui() translations. |
| packages/apollo-react/src/canvas/components/StageNode/useExecutionStatusLabel.ts | New hook to localize execution status labels (tooltip + a11y text). |
| packages/apollo-react/src/canvas/components/StageNode/useExecutionStatusLabel.test.ts | Unit tests for the new status→label mapping hook. |
| packages/apollo-react/src/canvas/components/StageNode/TaskContent.tsx | Uses localized status name for tooltip and aria-label on task status icon. |
| packages/apollo-react/src/canvas/components/StageNode/TaskContent.test.tsx | Adds tests validating tooltip/aria-label behavior for task status icon. |
| packages/apollo-react/src/canvas/components/StageNode/StageNodeHeader.tsx | Uses localized status name for aria-label and tooltip fallback. |
| packages/apollo-react/src/canvas/components/StageNode/StageNode.test.tsx | Adds Stage status tooltip/aria-label coverage. |
| packages/apollo-react/src/canvas/components/StageNode/StageNode.stories.tsx | Removes per-story locale arg in favor of global Storybook locale switching. |
| apps/storybook/.storybook/preview.tsx | Adds a locale toolbar; sets <html lang> and remounts stories on locale change. |
Contributor
uipath-utkarsh
left a comment
There was a problem hiding this comment.
Code review
Two findings worth addressing. Both surfaced from independent review passes and verified against the referenced code.
0ef3799 to
58f8cff
Compare
kittyyueli
reviewed
May 26, 2026
kittyyueli
approved these changes
May 26, 2026
58f8cff to
802ab62
Compare
802ab62 to
96a089e
Compare
96a089e to
9077291
Compare
uipath-utkarsh
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added general locale prop to affectively check the localization effect.
added localization to some sticky note left out strings
added stage and tasks status icons tooltip
Screen.Recording.2026-05-26.at.12.56.09.PM.mov