Conda and pypi publish workflow#4
Merged
cvanelteren merged 7 commits intoUltraplot:mainfrom Jan 6, 2025
Merged
Conversation
separated workflows separated workflows
beckermr
requested changes
Jan 4, 2025
Collaborator
beckermr
left a comment
beckermr
left a comment
There was a problem hiding this comment.
We need to submit the package to conda-forge/staged-recipes to distribute there. Let's delete the conda workflow bits since we do not need them.
Collaborator
Author
|
setup the recipe conda-forge/staged-recipes#28759 |
beckermr
reviewed
Jan 6, 2025
# This is the 1st commit message: added title to build job # This is the commit message Ultraplot#2: fixed removing wrong test
Collaborator
Author
|
Was drafting too much. Should be separated correctly now ;-)! |
beckermr
requested changes
Jan 6, 2025
Collaborator
beckermr
left a comment
beckermr
left a comment
There was a problem hiding this comment.
Once we delete the conda publish CI job, which is not needed, this one is good to go.
Collaborator
Author
|
Ready for merge? How do we handle the conda-side? I saw you change the PR on the recipes 😄 ! |
Collaborator
|
the conda package will get published by conda-forge's CI infrastructure and should already be up. In the future, all we need to do here is to make pypi releases and conda-forge's bot will send a PR to update the conda package. |
beckermr
approved these changes
Jan 6, 2025
Collaborator
Author
|
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial workflow to allow publication to pypi and conda. I would need some help with the conda part but I think it could be automated with a workflow. Pinging @beckermr for review