-
Notifications
You must be signed in to change notification settings - Fork 80
Upgrade to Gradle 9 and migrate to Kotlin DSL #1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0a156bc to
eb5472a
Compare
05b3c0c to
c1f00b0
Compare
d1128eb to
c92d323
Compare
Tests that extend TestCase do not properly work with JUnit4 Category filtering when running with JUnitPlatform, so migrate to use the JUnit4 @test annotations.
protoc for windows arm isn't included in the native jar produced by grpc at this point, so hold off testing on windows-11-arm platform.
c92d323 to
f874acf
Compare
|
With the move to Gradle 9, Java 17 is now required to run the build (the build will produce java 8 bytecode, so no change in the minimum version supported, and java 8 will be used by the build to run the tests). I tried to keep the build commands the same during this transition (e.g. There is no longer a New build system just in time for Halloween...spooky! |
|
Ooooph, some changes. A couple notes… I see some errors when doing a I had to dig around for a few minutes to figure out how to modify the config settings so as to include some extra items in my "x" build of netcdfAll., as there is no longer a Belatedly discovered the Java version requirement for building NJ via the new procedure after I deleted Java 25 from this particular Mac. Which okay, I can still update my copy of NJ but not so often. (You should see my archive of Java for Mac installers.) I still prefer to use an actual Java 11 to build my Java 11 app, as there were stories back in ye olden days that using a newer to target an older might trigger arcane bugs. |
|
Greetings @rschmunk! Next time I make build changes I'll be sure to tag you as a heads-up. I still need to update the project wiki to account for these changes, but that document is a bit out of date as-is. I could change the build to use a Java 8 toolchain for compiling the code, like I do with using Java 8 for running the tests. It would still require a Java 17+ install to run the build itself, but it would use JDK 8 for all of the compile steps. I decided to go with using the |
Description of Changes
Upgrade to Gradle 9 and migrate from the groovy DSL to the Kotlin DSL.
PR Checklist
until ready for review