Skip to content

fix: resolve zizmor GitHub Actions security findings#1114

Merged
dgilmanuni merged 12 commits intomainfrom
fix/zizmor-security-findings
Mar 10, 2026
Merged

fix: resolve zizmor GitHub Actions security findings#1114
dgilmanuni merged 12 commits intomainfrom
fix/zizmor-security-findings

Conversation

@dgilmanuni
Copy link
Contributor

@dgilmanuni dgilmanuni commented Feb 12, 2026

Summary

  • Ran zizmor static analysis on GitHub Actions workflows
  • Fixed credential persistence issues (persist-credentials: false)
  • Added minimal permissions blocks where missing
  • Bumped Node.js version from 18.20.4 to 20 in CI workflows (required by @docusaurus/core@3.9.2)
  • Fixed eslint errors in NotFound component (unused import, unescaped apostrophe)
  • Upgraded TypeScript from 4.9.5 to 5.9.3 (required by zod v4 type declarations)
  • Use Docusaurus default tsconfig settings (bundler moduleResolution, skipLibCheck)
  • Pinned @types/react to ^18.2.0 via resolutions to prevent conflicting React 19 types
  • Added type assertion for useDocsPreferredVersion return type
  • Excluded examples/ from type checking (references uninstalled packages)
  • Formatted all 25 files with prettier to pass CI formatting check

Generated by zizmor v1.22.0

🤖 Generated with Claude Code

- Added persist-credentials: false to checkout actions
- Added permissions: {} blocks to all workflow files

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Mar 10, 2026 9:25pm

Request Review

@docusaurus/core@3.9.2 requires Node.js >=20.0 but CI was using 18.20.4,
causing yarn install to fail on all push-triggered workflows.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove unused useEffect import and escape unescaped apostrophe in JSX.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Zod 4.x type declarations use const type parameters requiring TS >= 5.0,
but the project uses TS 4.9.5. skipLibCheck skips type checking .d.ts
files in node_modules, which is standard Docusaurus practice.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Zod v4 type declarations use const type parameters which require TS >= 5.0.
This was causing tsc --noEmit to fail with parser errors on zod .d.cts files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@socket-security
Copy link

socket-security bot commented Mar 10, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedtypescript@​4.9.5 ⏵ 5.9.3100 +11009010090

View full report

Remove moduleResolution and skipLibCheck overrides to inherit the
correct defaults from @docusaurus/tsconfig (bundler resolution,
skipLibCheck: true). The "node" moduleResolution override was causing
type resolution issues with TS 5.x and Docusaurus components.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add resolutions to pin @types/react to ^18.2.0 (prevents conflicting
  React 19 types from being installed, which causes 'cannot be used as
  JSX component' errors)
- Unify @types/react lockfile entries to 18.3.26
- Exclude examples/ from type checking (references uninstalled packages)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The bundler moduleResolution resolves Docusaurus types differently,
causing savePreferredVersionName to not exist on the inferred type.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Run prettier --write on all 25 files with formatting issues to pass
the CI formatting check.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…indings

# Conflicts:
#	docusaurus.config.ts
#	src/components/NewsletterForm/index.tsx
#	src/pages/index.tsx
#	src/theme/Navbar/Content/index.tsx
Fix eslint no-unescaped-entities errors in FeedbackForm.tsx and
run prettier on new files merged from main.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dgilmanuni dgilmanuni merged commit c58cf89 into main Mar 10, 2026
7 of 8 checks passed
@dgilmanuni dgilmanuni deleted the fix/zizmor-security-findings branch March 10, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants