refactor: remove check on internal CreateAndSpawnPlayer method#3914
Merged
noellie-velez merged 7 commits intodevelop-2.0.0from Mar 31, 2026
Merged
Conversation
EmandM
reviewed
Mar 25, 2026
com.unity.netcode.gameobjects/Runtime/Connection/NetworkConnectionManager.cs
Outdated
Show resolved
Hide resolved
EmandM
approved these changes
Mar 30, 2026
noellie-velez
commented
Mar 30, 2026
com.unity.netcode.gameobjects/Runtime/Connection/NetworkConnectionManager.cs
Outdated
Show resolved
Hide resolved
noellie-velez
commented
Mar 30, 2026
com.unity.netcode.gameobjects/Runtime/Connection/NetworkConnectionManager.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Remove check on internal CreateAndSpawnPlayer method, those checks should be done outside internal functions for readability questions and to avoid double checking.
Jira ticket
N/A
Changelog
N/A
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports