feat(docx-mcp): add MCP Apps preview with zero-residue isolation#45
Draft
stevenobiajulu wants to merge 3 commits intomainfrom
Draft
feat(docx-mcp): add MCP Apps preview with zero-residue isolation#45stevenobiajulu wants to merge 3 commits intomainfrom
stevenobiajulu wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Self-contained preview app in src/app/ — delete the directory + 2 lines from server.ts to fully remove. Includes interactive document preview (preview.html), get_document_view tool, resource handlers, and build copy step that no-ops when src/app/ is absent.
…gration tests Peer review by Codex (gpt-5.3) and Gemini surfaced 2 medium findings: - registerPreviewApp now takes a named options object instead of 4 positional args (reduces misuse risk) - Uses GET_DOCUMENT_VIEW_TOOL.name instead of string literal in routing - Adds 5 integration tests via InMemoryTransport + Client that verify tools/list, tools/call, resources/list, resources/read with and without preview registered
stevenobiajulu
force-pushed
the
feat/mcp-app-preview
branch
from
ddc8f4a to
b6eaf36
Compare
stevenobiajulu
changed the title
- Use 'Document Reading' epic instead of new 'MCP Apps' epic - Narrow content union type for resources/read assertion
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/app/— interactive document preview withget_document_viewtool, resource handlers, and HTML preview appsrc/app/+ remove 3 lines fromserver.tsto fully remove the featureregisterPreviewApp()owns all preview concerns: capabilities, ListTools/CallTool overrides, ListResources/ReadResource handlers@modelcontextprotocol/ext-appsdependency (CDN-only in HTML)src/app/is absentPeer review
Reviewed by Codex (gpt-5.3) and Gemini with full repo access. Findings addressed:
GET_DOCUMENT_VIEW_TOOL.nameTest plan
npm run build -w @usejunior/docx-mcppassessrc/app/+ remove lines → build passesui://safe-docx/preview, Apps tab renders preview