refactor: upgrade for cake4 #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This one almost works except there is a deprecated code usage in a dependency where the strategy is being tested (Tiny). Not sure what to do there. Also this stupid phpstan error around treating a Behavior instance as the thing it is... |
Contributor
Author
|
Okay I hacked around it for now via a phpunit xml attribute, which is good enough until it gets fixed upstream (pull request here). |
Member
|
Doesn't seem like |
dereuromark
reviewed
Mar 3, 2020
ADmad
requested changes
Mar 3, 2020
Member
ADmad
left a comment
ADmad
left a comment
There was a problem hiding this comment.
The CONTRIBUTING.md has stuff which are not relevant to this repo. There's no gh-pages branch, there's no docker file etc. Best to just remove it.
ADmad
reviewed
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.