build(deps): bump uuid and matrix-js-sdk#683
Open
dependabot[bot] wants to merge 4 commits into
Open
Conversation
dependabot
Bot
added
dependencies
Removes [uuid](https://github.com/uuidjs/uuid). It's no longer used after updating ancestor dependency [matrix-js-sdk](https://github.com/matrix-org/matrix-js-sdk). These dependencies need to be updated together. Removes `uuid` Updates `matrix-js-sdk` from 24.1.0 to 41.6.0 - [Release notes](https://github.com/matrix-org/matrix-js-sdk/releases) - [Changelog](https://github.com/matrix-org/matrix-js-sdk/blob/develop/CHANGELOG.md) - [Commits](matrix-org/matrix-js-sdk@v24.1.0...v41.6.0) --- updated-dependencies: - dependency-name: matrix-js-sdk dependency-version: 41.6.0-rc.0 dependency-type: direct:production - dependency-name: uuid dependency-version: dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot-npm_and_yarn-multi-5c230cad76
branch
from
f9c1fcf to
c584bcb
Compare
Contributor
|
@copilot make sure all the checks passes. Analyse the failed checks and fix them |
- tsconfig.json: add es2021 to lib for AggregateError (fixes TS2304) - SynapseService.ts: replace static ESM import with lazy dynamic import() using private getMatrix()/getClient() methods; define local IMatrixClient interface to avoid import type TS1541/TS1542 errors with module:Node16 - SynapseService.spec.ts: replace jest.requireActual with explicit mock values (fixes ESM load failure); add Method/Visibility/EventType/MsgType enum values to mock - jest.unit.config.js: set module:CommonJS + moduleResolution:node for ts-jest so dynamic import() compiles as require() that Jest can mock
auto-merge was automatically disabled
May 29, 2026 09:08
Head branch was pushed to by a user without write access
- Replace `sdkCache: any` with typed `IMatrixSdk` interface - Remove redundant `!` non-null assertion from `getClient()` - Remove unnecessary `as any` cast on `sendEvent` content arg
Contributor
All checks are now fixed. Here's a summary of what was done:
All 161 tests pass and lint is clean. |
There was a problem hiding this comment.
Pull request overview
Updates the connector’s Matrix/Synapse integration to work with matrix-js-sdk@41.6.0 and removes reliance on the SDK’s exported TS types by switching to a minimal local interface + lazy SDK import.
Changes:
- Bump
matrix-js-sdkfrom24.1.0to41.6.0(and corresponding lockfile updates;uuidremoved as a transitive dependency). - Refactor
SynapseServiceto dynamically importmatrix-js-sdkand use locally-defined minimal client/SDK interfaces. - Adjust Jest setup/mocks and TS/Jest compilation settings (adds
es2021lib; ts-jest module settings).
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Adds es2021 to the TS lib set. |
| src/services/synapse/SynapseService.ts | Switches to lazy-loading matrix-js-sdk and replaces SDK type imports with minimal local interfaces. |
| src/services/synapse/SynapseService.spec.ts | Updates matrix-js-sdk mocking to match the new dynamic-import usage and exported constants. |
| jest.unit.config.js | Overrides ts-jest module settings to CommonJS/node resolution for tests. |
| package.json | Bumps matrix-js-sdk to 41.6.0. |
| package-lock.json | Lockfile refresh for the new matrix-js-sdk dependency tree (including crypto wasm, retry stack changes, removal of transitive uuid). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| private clientCache: IMatrixClient | undefined; | ||
|
|
||
| constructor() { | ||
| if (!serverUrl) throw new Error('SYNAPSE_SERVER_NAME is not set'); |
| "kafkajs": "^2.2.4", | ||
| "knex": "^3.2.4", | ||
| "matrix-js-sdk": "24.1.0", | ||
| "matrix-js-sdk": "41.6.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes uuid. It's no longer used after updating ancestor dependency matrix-js-sdk. These dependencies need to be updated together.
Removes
uuidUpdates
matrix-js-sdkfrom 24.1.0 to 41.6.0Release notes
Sourced from matrix-js-sdk's releases.
... (truncated)
Changelog
Sourced from matrix-js-sdk's changelog.
... (truncated)
Commits
c32cf14v41.6.0fa4f56dv41.6.0-rc.0b125ef6Merge branch 'master' into developc90237cv41.5.0d4739cbUpdate pnpm/action-setup action to v6 (#5296)349e8c5Update dependency@typescript-eslint/parserto v8.59.2 (#5323)de8f011Update dependency@typescript-eslint/eslint-pluginto v8.59.2 (#5322)8455876Throw sane error on completeLoginOnNewDevice IdP rejection (#5321)62943bdUpdate npm non-major dependencies (#5317)9d5611cUpdate tspascoal/get-user-teams-membership action to v4 (#5320)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for matrix-js-sdk since your current version.
Install script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.