fix: update amqp lib to support rabbitmq4.x#235
Open
Bhaswati1148 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the amqplib dependency in
@user-office-software/duo-message-brokerfrom 0.10.3 to 0.10.9 to ensure compatibility with RabbitMQ 4.xMotivation and Context
In STFC, we are currently upgrading RabbitMQ from version 3.12.x to 4.x.
RabbitMQ 4.x introduces stricter AMQP connection negotiation rules and enforces a minimum allowed
frame_maxvalue of8192during connection setup. Older versions of amqplib (including the currently used 0.10.3) default to aframe_maxvalue of4096, which results in connection failures when connecting to RabbitMQ 4.x brokers.Reference: amqp-node/amqplib#787
We are intentionally upgrading to 0.10.9 instead of the latest major version of
amqplibbecause the RabbitMQ 4.x compatibility fix is available starting from 0.10.7. Upgrading within the same major version minimizes the risk of introducing unrelated breaking changes in the message broker package.How Has This Been Tested
Tested locally against RabbitMQ 4.3.0 by configuring the RabbitMQ
frame_maxvalue to131072.Fixes
Changes
Depends on
Tests included/Docs Updated?