Skip to content

Fix Yr weather codes "lightsleet" and "heavysnowshowers_polartwilight"#381

Merged
JanPetterMG merged 2 commits intomainfrom
ai-findings-autofix/firmware-include-modes-YrMode.h
Feb 27, 2026
Merged

Fix Yr weather codes "lightsleet" and "heavysnowshowers_polartwilight"#381
JanPetterMG merged 2 commits intomainfrom
ai-findings-autofix/firmware-include-modes-YrMode.h

Conversation

@JanPetterMG
Copy link
Contributor

@JanPetterMG JanPetterMG commented Feb 27, 2026

Fixes an issue where the weather codes heavysnowshowers_polartwilight and lightsleet was compiled into heavysnowshowers_polartwilightlightsleet instead of staying separate as two different weather codes.

Looks like this bug has existed since v1.0.0

PR #383 is required before this PR can be merged.

This PR applies 1/1 suggestions from code quality AI findings.

…utofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@github-actions github-actions bot added the firmware C++ related label Feb 27, 2026
@JanPetterMG JanPetterMG added the bug Something isn't working label Feb 27, 2026
@JanPetterMG JanPetterMG added this to the v2.3.0 milestone Feb 27, 2026
@JanPetterMG JanPetterMG self-assigned this Feb 27, 2026
@JanPetterMG JanPetterMG changed the title Potential fix for 1 code quality finding Fix Yr weather codes "lightsleet" and "heavysnowshowers_polartwilight" Feb 27, 2026
@JanPetterMG JanPetterMG marked this pull request as ready for review February 27, 2026 02:46
@JanPetterMG JanPetterMG merged commit 5f5bb05 into main Feb 27, 2026
152 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Frekvens roadmap Feb 27, 2026
@JanPetterMG JanPetterMG deleted the ai-findings-autofix/firmware-include-modes-YrMode.h branch February 27, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working firmware C++ related

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant