Skip to content

Enforce milestone validation before creating PlatformIO dependency PRs#390

Merged
JanPetterMG merged 1 commit intomainfrom
piobot-milestone-check
Feb 27, 2026
Merged

Enforce milestone validation before creating PlatformIO dependency PRs#390
JanPetterMG merged 1 commit intomainfrom
piobot-milestone-check

Conversation

@JanPetterMG
Copy link
Contributor

This PR introduces a fail-fast milestone validation step in the dependency update workflows.

Before invoking peter-evans/create-pull-request, the workflow now verifies that:

  • The configured milestone exists
  • The milestone is open

If the milestone is missing or closed, the workflow fails immediately.

Rationale

Previously, PR creation could fail during the pull request creation step when:

  • The milestone existed but was closed
  • The milestone ID did not exist (common in forks)

This could lead to repeated failed runs and PR stacking behavior.

By validating the milestone explicitly and early, the workflow:

  • Fails deterministically
  • Avoids partial PR creation attempts
  • Prevents unnecessary PR accumulation
  • Makes milestone configuration errors immediately visible

This change improves workflow robustness, especially in fork scenarios where milestone numbers differ or are absent.

@JanPetterMG JanPetterMG added chore This issue or pull request is a maintenance task no-changelog Do not include in release notes labels Feb 27, 2026
@JanPetterMG JanPetterMG added this to the v2.3.0 milestone Feb 27, 2026
@JanPetterMG JanPetterMG enabled auto-merge (squash) February 27, 2026 20:00
@JanPetterMG JanPetterMG merged commit 9e516fe into main Feb 27, 2026
152 checks passed
@JanPetterMG JanPetterMG deleted the piobot-milestone-check branch February 27, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This issue or pull request is a maintenance task no-changelog Do not include in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant