Develop

.claude/agents/code-reviewer.md

@@ -0,0 +1,36 @@
+---
+name: code-reviewer
+description: Reviews C# code for Unity/Editor boundary violations, generator correctness, and package conventions
+---
+
+You are a C# code reviewer specializing in Unity packages and Roslyn source generators. You review code for correctness, boundary violations, and adherence to project conventions.
+
+## Project Context
+
+This is **Aspid.FastTools** — a Unity package (`com.aspid.fasttools`) with two separate projects:
+- `Aspid.FastTools/` — Unity project (Runtime + Editor assemblies)
+- `Aspid.FastTools.Generators/` — .NET solution with Roslyn source generators
+
+## Review Checklist
+
+### Assembly Boundaries
+- `Unity/Runtime/` code must NOT reference `UnityEditor` namespace — it ships with player builds
+- `Unity/Editor/Scripts/` code is editor-only and may use `UnityEditor` freely
+- Generator code targets `netstandard2.0` and must NOT reference any Unity assemblies
+
+### Generators (`Aspid.FastTools.Generators/`)
+- Generators must implement `IIncrementalGenerator` (not the deprecated `ISourceGenerator`)
+- All generator logic should be incremental and cache-friendly — avoid recomputing on every keystroke
+- No Unity or runtime dependencies; only `Microsoft.CodeAnalysis.CSharp` and `Aspid.Generators.Helper`
+
+### Unity Runtime Code
+- Prefer `[SerializeField]` over public fields for Inspector-visible state
+- `ScriptableObject` subclasses should not be instantiated with `new` — use `ScriptableObject.CreateInstance`
+- Extension methods on `VisualElement` should follow the fluent pattern already established in `VisualElementExtensions.*`
+
+### General C# Quality
+- Nullable annotations must be consistent — the project has `<Nullable>enable</Nullable>`
+- Avoid boxing of value types in hot paths (ProfilerMarkers, EnumValues iteration)
+- Partial classes must all reside in files named consistently with the partial suffix pattern used elsewhere
+
+Report issues grouped by severity: **Error** (breaks compilation or runtime), **Warning** (likely bug or convention violation), **Info** (minor improvement).

.claude/skills/build-generator/SKILL.md

@@ -0,0 +1,13 @@
+---
+name: build-generator
+description: Build Roslyn source generators and deploy the resulting DLL into the Unity package
+user-invocable: true
+---
+
+Build the Aspid.FastTools source generators and deploy to Unity:
+
+1. Run `dotnet build Aspid.FastTools.Generators/Aspid.FastTools.Generators/Aspid.FastTools.Generators.csproj -c Release` from the repository root
+2. Copy `Aspid.FastTools.Generators/Aspid.FastTools.Generators/bin/Release/netstandard2.0/Aspid.FastTools.Generators.dll` to `Aspid.FastTools/Assets/Plugins/Aspid/FastTools/Aspid.FastTools.Generators.dll`
+3. Report the result: build output, any errors, and confirm the DLL was copied successfully
+
+Arguments: $ARGUMENTS (optional: pass `Debug` to build in Debug configuration instead of Release)

.gitignore

@@ -0,0 +1 @@
+.claude/settings.local.json

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "Aspid.FastTools/Assets/Plugins/Aspid/Internal/Unity"]
+	path = Aspid.FastTools/Assets/Plugins/Aspid/Internal/Unity
+	url = git@github.com:VPDPersonal/Aspid.Internal.Unity.git

Aspid.UnityFastTools.Generators/UnityFastToolsGenerators/Aspid.UnityFastTools.Generators.Sample/Aspid.UnityFastTools.Generators.Sample.csproj → Aspid.FastTools.Generators/Aspid.FastTools.Generators.Sample/Aspid.FastTools.Generators.Sample.csproj

@@ -3,13 +3,13 @@
     <PropertyGroup>
         <TargetFramework>net6.0</TargetFramework>
         <Nullable>enable</Nullable>
-        <RootNamespace>UnityFastToolsGenerators.Sample</RootNamespace>
+        <RootNamespace>Aspid.FastTools.Sample</RootNamespace>
         <UnityVersion>6000.2.7f2</UnityVersion>
         <LangVersion>9</LangVersion>
     </PropertyGroup>
 
     <ItemGroup>
-        <ProjectReference Include="..\Aspid.UnityFastTools.Generators\Aspid.UnityFastTools.Generators.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
+        <ProjectReference Include="..\Aspid.FastTools.Generators\Aspid.FastTools.Generators.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
     </ItemGroup>
 
     <ItemGroup>

Aspid.UnityFastTools.Generators/UnityFastToolsGenerators/Aspid.UnityFastTools.Generators.Tests/Aspid.UnityFastTools.Generators.Tests.csproj → Aspid.FastTools.Generators/Aspid.FastTools.Generators.Tests/Aspid.FastTools.Generators.Tests.csproj

@@ -6,7 +6,7 @@
 
         <IsPackable>false</IsPackable>
 
-        <RootNamespace>UnityFastToolsGenerators.Tests</RootNamespace>
+        <RootNamespace>Aspid.FastTools.Tests</RootNamespace>
     </PropertyGroup>
 
     <ItemGroup>
@@ -20,7 +20,7 @@
     </ItemGroup>
 
     <ItemGroup>
-        <ProjectReference Include="..\Aspid.UnityFastTools.Generators\Aspid.UnityFastTools.Generators.csproj" />
+        <ProjectReference Include="..\Aspid.FastTools.Generators\Aspid.FastTools.Generators.csproj" />
     </ItemGroup>
 
 

Aspid.UnityFastTools.Generators/Aspid.UnityFastTools.Generators.sln → Aspid.FastTools.Generators/Aspid.FastTools.Generators.sln

@@ -1,10 +1,10 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Aspid.UnityFastTools.Generators", "UnityFastToolsGenerators\Aspid.UnityFastTools.Generators\Aspid.UnityFastTools.Generators.csproj", "{CB9D8D51-7D86-4B84-A0DB-73E418962DA7}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Aspid.FastTools.Generators", "Aspid.FastTools.Generators\Aspid.FastTools.Generators.csproj", "{CB9D8D51-7D86-4B84-A0DB-73E418962DA7}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Aspid.UnityFastTools.Generators.Sample", "UnityFastToolsGenerators\Aspid.UnityFastTools.Generators.Sample\Aspid.UnityFastTools.Generators.Sample.csproj", "{2835DD81-D105-4C2E-AE03-BC7D064C29D1}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Aspid.FastTools.Generators.Sample", "Aspid.FastTools.Generators.Sample\Aspid.FastTools.Generators.Sample.csproj", "{2835DD81-D105-4C2E-AE03-BC7D064C29D1}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Aspid.UnityFastTools.Generators.Tests", "UnityFastToolsGenerators\Aspid.UnityFastTools.Generators.Tests\Aspid.UnityFastTools.Generators.Tests.csproj", "{F4953608-2F14-4B2E-B91C-B3FDFC81B180}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Aspid.FastTools.Generators.Tests", "Aspid.FastTools.Generators.Tests\Aspid.FastTools.Generators.Tests.csproj", "{F4953608-2F14-4B2E-B91C-B3FDFC81B180}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution

Aspid.UnityFastTools.Generators/UnityFastToolsGenerators/Aspid.UnityFastTools.Generators/Aspid.UnityFastTools.Generators.csproj → Aspid.FastTools.Generators/Aspid.FastTools.Generators/Aspid.FastTools.Generators.csproj

@@ -3,9 +3,9 @@
     <PropertyGroup>
         <TargetFramework>netstandard2.0</TargetFramework>
         <Nullable>enable</Nullable>
-        <LangVersion>13</LangVersion>
+        <LangVersion>latest</LangVersion>
         <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
-        <RootNamespace>UnityFastToolsGenerators</RootNamespace>
+        <RootNamespace>Aspid.FastTools</RootNamespace>
     </PropertyGroup>
 
     <ItemGroup>

Aspid.FastTools.Generators/Aspid.FastTools.Generators/Descriptions/General.cs

@@ -0,0 +1,8 @@
+using Aspid.Generators.Helper;
+
+namespace Aspid.FastTools.Descriptions;
+
+public static class General
+{
+    public static readonly string ProfilerMarkerGeneratedCode = $"""{Classes.GeneratedCodeAttribute}("Aspid.FastTools.Generators.ProfilerMarkersGenerator", "1.0.0")""";
+}

Aspid.FastTools.Generators/Aspid.FastTools.Generators/Generators/IdStruct/Bodies/IdStructBody.cs

@@ -0,0 +1,33 @@
+using Microsoft.CodeAnalysis;
+using Aspid.Generators.Helper;
+using Aspid.FastTools.Generators.IdStruct.Data;
+
+namespace Aspid.FastTools.Generators.IdStruct.Bodies;
+
+public static class IdStructBody
+{
+    public static void GenerateCode(in SourceProductionContext context, in IdStructData data)
+    {
+        var hasNamespace = data.Namespace != null;
+
+        var code = new CodeWriter()
+            .AppendLine("// <auto-generated>")
+            .AppendLine("#nullable enable")
+            .AppendLine()
+            .AppendLineIf(hasNamespace, $"namespace {data.Namespace}")
+            .BeginBlockIf(hasNamespace)
+            .AppendLine($"partial struct {data.StructName}")
+            .BeginBlock()
+            .AppendLine("#if UNITY_EDITOR")
+            .AppendLine("[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]")
+            .AppendLine("[global::UnityEngine.SerializeField] private string __stringId;")
+            .AppendLine("#endif")
+            .AppendLine("[global::UnityEngine.SerializeField] private int _id;")
+            .AppendLine("public int Id => _id;")
+            .EndBlock()
+            .EndBlockIf(hasNamespace);
+
+        var hintName = $"{data.StructName}.IId.g.cs";
+        context.AddSource(hintName, code.GetSourceText());
+    }
+}

Aspid.FastTools.Generators/Aspid.FastTools.Generators/Generators/IdStruct/Data/IdStructData.cs

@@ -0,0 +1,12 @@
+using Microsoft.CodeAnalysis;
+
+namespace Aspid.FastTools.Generators.IdStruct.Data;
+
+public readonly struct IdStructData(INamedTypeSymbol symbol)
+{
+    public readonly INamedTypeSymbol Symbol = symbol;
+    public readonly string StructName = symbol.Name;
+    public readonly string? Namespace = symbol.ContainingNamespace.IsGlobalNamespace
+        ? null
+        : symbol.ContainingNamespace.ToDisplayString();
+}

Aspid.FastTools.Generators/Aspid.FastTools.Generators/Generators/IdStruct/IdStructGenerator.cs

@@ -0,0 +1,50 @@
+using System.Threading;
+using Microsoft.CodeAnalysis;
+using Microsoft.CodeAnalysis.CSharp;
+using Microsoft.CodeAnalysis.CSharp.Syntax;
+using Aspid.FastTools.Generators.IdStruct.Data;
+using Aspid.FastTools.Generators.IdStruct.Bodies;
+
+namespace Aspid.FastTools.Generators.IdStruct;
+
+[Generator(LanguageNames.CSharp)]
+public class IdStructGenerator : IIncrementalGenerator
+{
+    private const string IIdFullName = "Aspid.FastTools.IId";
+
+    public void Initialize(IncrementalGeneratorInitializationContext context)
+    {
+        var provider = context.SyntaxProvider
+            .CreateSyntaxProvider(Predicate, Transform)
+            .Where(static d => d.HasValue)
+            .Select(static (d, _) => d!.Value);
+
+        context.RegisterSourceOutput(provider, static (ctx, data) => IdStructBody.GenerateCode(ctx, data));
+    }
+
+    private static bool Predicate(SyntaxNode node, CancellationToken _)
+    {
+        if (node is not StructDeclarationSyntax structDecl) return false;
+        if (!structDecl.Modifiers.Any(SyntaxKind.PartialKeyword)) return false;
+        return structDecl.BaseList is { Types.Count: > 0 };
+    }
+
+    private static IdStructData? Transform(GeneratorSyntaxContext context, CancellationToken ct)
+    {
+        var structDecl = (StructDeclarationSyntax)context.Node;
+
+        if (context.SemanticModel.GetDeclaredSymbol(structDecl, ct) is not INamedTypeSymbol symbol)
+            return null;
+
+        var iidInterface = context.SemanticModel.Compilation.GetTypeByMetadataName(IIdFullName);
+        if (iidInterface == null) return null;
+
+        foreach (var iface in symbol.AllInterfaces)
+        {
+            if (SymbolEqualityComparer.Default.Equals(iface, iidInterface))
+                return new IdStructData(symbol);
+        }
+
+        return null;
+    }
+}

Aspid.UnityFastTools.Generators/UnityFastToolsGenerators/Aspid.UnityFastTools.Generators/Generators/ProfilerMarkers/Bodies/ExtensionClassBody.cs → Aspid.FastTools.Generators/Aspid.FastTools.Generators/Generators/ProfilerMarkers/Bodies/ExtensionClassBody.cs

@@ -2,20 +2,20 @@
 using Microsoft.CodeAnalysis;
 using Aspid.Generators.Helper;
 using System.Collections.Immutable;
-using UnityFastToolsGenerators.Generators.ProfilerMarkers.Data;
+using Aspid.FastTools.Generators.ProfilerMarkers.Data;
 using static Aspid.Generators.Helper.Classes;
+using static Aspid.FastTools.Descriptions.General;
 using static Aspid.Generators.Helper.Unity.UnityClasses;
-using static UnityFastToolsGenerators.Descriptions.General;
 
-namespace UnityFastToolsGenerators.Generators.ProfilerMarkers.Bodies;
+namespace Aspid.FastTools.Generators.ProfilerMarkers.Bodies;
 
 public static class ExtensionClassBody
 {
     public static void GenerateCode(in SourceProductionContext context, in ImmutableArray<MarkerCall> markerCalls)
     {
         var markerCallTypes = markerCalls
             .GroupBy(markerCall => markerCall.NamedTypeSymbol, SymbolEqualityComparer.Default)
-            .Select(group => new MarkerCallType(group.Key!, group.ToImmutableArray()));
+            .Select(group => new MarkerCallType((INamedTypeSymbol)group.Key!, group.ToImmutableArray()));
 
         foreach (var markerCallType in markerCallTypes)
             GenerateCode(context, markerCallType);
@@ -28,13 +28,14 @@ private static void GenerateCode(in SourceProductionContext context, in MarkerCa
 
         var hasNamespaceName = !symbol.ContainingNamespace.IsGlobalNamespace;
         var namespaceName = hasNamespaceName ? symbol.ContainingNamespace.ToDisplayString() : null;
-        
+
         var markerCallMembers = type.MarkerCalls
             .GroupBy(markerCall => markerCall.MethodSymbol, SymbolEqualityComparer.Default)
             .Select(grouping => new MarkerCallMember((IMethodSymbol)grouping.Key!, grouping.ToImmutableArray()))
             .ToImmutableArray();
 
-        var className = $"__{typeName}ProfilerMarkerExtensions";
+        var arityPart = symbol.Arity > 0 ? $"_{symbol.Arity}" : string.Empty;
+        var className = $"__{typeName}{arityPart}ProfilerMarkerExtensions";
 
         var code = new CodeWriter()
             .AppendLine("// <auto-generated>")
@@ -76,11 +77,16 @@ private static CodeWriter AppendProfilerMarkers(this CodeWriter code, ImmutableA
 
     private static CodeWriter AppendWithoutMessage(
         this CodeWriter code,
-        ISymbol symbol,
+        INamedTypeSymbol symbol,
         ImmutableArray<MarkerCallMember> markerCallMembers)
     {
+        var typeParams = symbol.TypeParameters;
+        var typeParamList = typeParams.Length > 0
+            ? $"<{string.Join(", ", typeParams.Select(p => p.Name))}>"
+            : string.Empty;
+
         code.AppendLine($"[{ProfilerMarkerGeneratedCode}]")
-            .AppendLine($"public static {ProfilerMarker}.AutoScope Marker(this {symbol.ToDisplayStringGlobal()} _, [{CallerLineNumberAttribute}] int line = -1)")
+            .AppendLine($"public static {ProfilerMarker}.AutoScope Marker{typeParamList}(this {symbol.ToDisplayStringGlobal()} _, [{CallerLineNumberAttribute}] int line = -1)")
             .BeginBlock();
 
         foreach (var markerCall in markerCallMembers.SelectMany(member => member.MarkerCalls))

Aspid.UnityFastTools.Generators/UnityFastToolsGenerators/Aspid.UnityFastTools.Generators/Generators/ProfilerMarkers/Data/MarkerCall.cs → Aspid.FastTools.Generators/Aspid.FastTools.Generators/Generators/ProfilerMarkers/Data/MarkerCall.cs

@@ -1,6 +1,6 @@
 using Microsoft.CodeAnalysis;
 
-namespace UnityFastToolsGenerators.Generators.ProfilerMarkers.Data;
+namespace Aspid.FastTools.Generators.ProfilerMarkers.Data;
 
 public readonly struct MarkerCall(
     INamedTypeSymbol namedTypeSymbol,

Aspid.UnityFastTools.Generators/UnityFastToolsGenerators/Aspid.UnityFastTools.Generators/Generators/ProfilerMarkers/Data/MarkerCallMember.cs → Aspid.FastTools.Generators/Aspid.FastTools.Generators/Generators/ProfilerMarkers/Data/MarkerCallMember.cs

@@ -1,7 +1,7 @@
 using Microsoft.CodeAnalysis;
 using System.Collections.Immutable;
 
-namespace UnityFastToolsGenerators.Generators.ProfilerMarkers.Data;
+namespace Aspid.FastTools.Generators.ProfilerMarkers.Data;
 
 public readonly struct MarkerCallMember(
     IMethodSymbol methodSymbol,

Aspid.UnityFastTools.Generators/UnityFastToolsGenerators/Aspid.UnityFastTools.Generators/Generators/ProfilerMarkers/Data/MarkerCallType.cs → Aspid.FastTools.Generators/Aspid.FastTools.Generators/Generators/ProfilerMarkers/Data/MarkerCallType.cs

@@ -1,12 +1,12 @@
 using Microsoft.CodeAnalysis;
 using System.Collections.Immutable;
 
-namespace UnityFastToolsGenerators.Generators.ProfilerMarkers.Data;
+namespace Aspid.FastTools.Generators.ProfilerMarkers.Data;
 
 public readonly struct MarkerCallType(
-    ISymbol symbol,
+    INamedTypeSymbol symbol,
     ImmutableArray<MarkerCall> markerCalls)
 {
-    public readonly ISymbol Symbol = symbol;
+    public readonly INamedTypeSymbol Symbol = symbol;
     public readonly ImmutableArray<MarkerCall> MarkerCalls = markerCalls;
 }

Aspid.UnityFastTools.Generators/UnityFastToolsGenerators/Aspid.UnityFastTools.Generators/Generators/ProfilerMarkers/ProfilerMarkersGenerator.cs → Aspid.FastTools.Generators/Aspid.FastTools.Generators/Generators/ProfilerMarkers/ProfilerMarkersGenerator.cs

@@ -2,10 +2,10 @@
 using Microsoft.CodeAnalysis;
 using System.Collections.Immutable;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
-using UnityFastToolsGenerators.Generators.ProfilerMarkers.Data;
-using UnityFastToolsGenerators.Generators.ProfilerMarkers.Bodies;
+using Aspid.FastTools.Generators.ProfilerMarkers.Data;
+using Aspid.FastTools.Generators.ProfilerMarkers.Bodies;
 
-namespace UnityFastToolsGenerators.Generators.ProfilerMarkers;
+namespace Aspid.FastTools.Generators.ProfilerMarkers;
 
 [Generator(LanguageNames.CSharp)]
 public class ProfilerMarkersGenerator : IIncrementalGenerator

Aspid.FastTools.Generators/Directory.Build.targets

@@ -0,0 +1,11 @@
+<Project>
+
+    <Target Name="CopyToUnity" AfterTargets="Build" Condition="'$(IsRoslynComponent)' == 'true'">
+        <PropertyGroup>
+            <_UnityDestination>$(MSBuildThisFileDirectory)../Aspid.FastTools/Assets/Plugins/Aspid/FastTools/</_UnityDestination>
+        </PropertyGroup>
+        <MakeDir Directories="$(_UnityDestination)" />
+        <Copy SourceFiles="$(TargetPath)" DestinationFolder="$(_UnityDestination)" SkipUnchangedFiles="true" />
+    </Target>
+
+</Project>