Add macOS binary build to release workflow#1890
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.13' | ||
|
|
There was a problem hiding this comment.
macOS job missing Python setup for pip command
High Severity
The new build-macos job uses pip index versions in the PyPI propagation check (line 339) but is missing the Set up Python step that the build-windows job has. The PR description explicitly mentions that Python setup was added to Windows "to ensure pip is available for the PyPI propagation check" - the same setup is needed for macOS. Without it, the macOS build will fail when pip isn't properly available in PATH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for building and distributing macOS (ARM) binaries in the release workflow.
Changes
release.yml:
build-macosjob that runs onmacos-latest(Apple Silicon), waits for PyPI propagation, builds bothvws-macosandvuforia-cloud-reco-macosbinaries using PyInstaller, and uploads the binaries to the GitHub releaseactions/setup-python@v5to the Windows build job to ensurepipis available for the PyPI propagation checkREADME.rst: Added a new "Pre-built macOS (ARM) binaries" section that points to the full documentation
docs/source/install.rst: Added detailed installation instructions for macOS binaries including:
xattr -d com.apple.quarantine)This follows the same pattern as the existing Windows and Linux binary builds.
Note
Introduces macOS binary distribution and stabilizes Windows release steps.
build-macosjob onmacos-latestbuildsvws-macosandvuforia-cloud-reco-macosvia PyInstaller and uploads them to the GitHub release after waiting for PyPI propagationactions/setup-python@v5to ensurepipis available for the PyPI version checkpip index versionsfor propagation verification before building binariesWritten by Cursor Bugbot for commit 771d92e. This will update automatically on new commits. Configure here.