fix: Skip read-only properties in mock resolution#468
Merged
MSchmoecker merged 1 commit intoValheim-Modding:devfrom Mar 6, 2026
Merged
Conversation
Prevents ArgumentException when FixMemberReferences encounters read-only properties like Component.transform by adding a HasSetMethod check before calling SetValue.
MSchmoecker
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HasSetMethodproperty toMemberBaseto track whether a member has a setterSetValuecalls inMockManager.FixMemberReferenceswithHasSetMethodcheck, preventing crashes on read-only properties likeComponent.transformProblem
When mods trigger
FixReferenceson GameObjects with read-only component properties (e.g.Component.transform),MockManager.FixMemberReferencescrashes with:The method iterates all properties via reflection and calls
SetValuewithout checking if a setter exists.Steps to reproduce
ZoneSystem.Start, EWD triggersSoftReference.Load()on MWL location prefabsAssetManager.SwapResolvedAssethook fires, callingPrefabExtension.FixReferenceson the loaded prefabMockManager.FixMemberReferencesencounters read-only properties likeComponent.transformand crashes callingSetValueFix
Follows the existing
HasGetMethodpattern — adds a symmetricHasSetMethodproperty and checks it beforeSetValuecalls in the two branches that write values back.