fix(theme): remove ember-this-fallback usage for Discourse 2026.4+ / Ember 6.10#74
Open
rapekas wants to merge 4 commits into
Open
fix(theme): remove ember-this-fallback usage for Discourse 2026.4+ / Ember 6.10#74rapekas wants to merge 4 commits into
rapekas wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72
Problem
On Discourse 2026.4.0-latest / Ember 6.10.1, the theme bundle fails to load with:
Could not find module 'ember-this-fallback/js-component' imported from (require)Discourse no longer ships the
ember-this-fallbackcompatibility layer; theme templates that still go through the old this-property-fallback pipeline can emitrequire()calls forember-this-fallback/js-component(and related paths likeis-component).Root cause in this theme
right-sidebar-blocks-below.hbs— standalone.hbsfor a theme component is compiled on a path that still depends onember-this-fallbackhelpers.{{yield}}infkb-panel.gjs— inside the badges{{#each}},yieldis not a real block API for this component; the AST can be treated as an ambiguous path and wrapped with fallback helpers that pull in removed modules.Changes
javascripts/discourse/components/right-sidebar-blocks-below.hbswithright-sidebar-blocks-below.gjs:settings.right_sidebar_below_fkb_panelinstead of(theme-setting ...).getOwner(this).resolveRegistration("component:right-sidebar-blocks")and render with<this.rightSidebarBlocks />(no legacy.hbs; no#letneeded).fkb-panel.gjs: remove the erroneous{{yield}}from the badge loop.Verification
right_sidebar_below_fkb_panel.theme-javascripts/*.jshash changes and the orange admin banner is gone.ember-this-fallback/*errors for this theme.References
.hbsin themes and plugins