Categorical Calibration Support #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns and allow class based calibration creation/modification - Allowed class based calibration creation in CalibrationEditor.vue. - Transitioned to form data in CalibrationEditor.vue invokers to reflect class based file upload. - Updated CalibrationTable.vue to replace functional ranges with functional classifications. - Modified ScoreSetHeatmap.vue to handle functional classifications in heatmap calculations. - Adjusted ScoreSetHistogram.vue to utilize functional classifications for histogram shaders. - Revised VariantMeasurementView.vue to check against functional classifications instead of ranges. - Enhanced ScoreSetCalibrationsView.vue to display functional classification counts and handle empty states. - Updated ScoreSetCreator.vue to validate functional classifications during calibration creation. - Refined ScoreSetView.vue to include classes draft reference in the calibration editor. - Improved SearchVariantsScreen.vue to filter score calibrations based on functional classifications. - Cleaned up calibrations.ts by removing outdated interfaces and adapting functions to use new schema components.
… from variant scores when a calibration is class based
…categorical class names
…attempts on score set creator
bencap
force-pushed
the
feature/bencap/categorical-calibrations
branch
from
8b48379 to
f3e7d9a
Compare
…leRef in ScoreSetView This annotation in a JS file was causing the automatic linter to strip parenthesis from the ref definition, making the classes flie undefined in all cases and preventing it from being saved when set.
Includes some automatic formatting changes from linter.
…ncy in ScoreSetCreator
Collaborator
|
I know there's still some rebasing or merging to do, but the current version is behaving as expected for all the cases I've tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates several components to support a class-based calibration model introduced by VariantEffect/mavedb-api#589.
Migration to new schema types and properties:
functionalRangesand theFunctionalRangetype withfunctionalClassificationsand the corresponding OpenAPI-generated types throughoutAssayFactSheet.vue,CalibrationTable.vue, andScoreSetHeatmap.vue. This includes updating computed properties, method signatures, and template logic to use the new structure. [1] [2] [3] [4] [5] [6] [7] [8] [9]Enhancements to CalibrationTable functionality:
functionalClassificationsare present and class-based. This includes new computed properties and template sections for rendering this information. [1] [2] [3]Visualization Improvements:
Template and display improvements:
AssayFactSheet.vueto explicitly type keyword lookups and improve readability, ensuring correct access to experiment keywords and their labels. [1] [2] [3]CalibrationTable.vueto "Functional classification" for clarity.Type safety and prop improvements:
components['schemas']['ScoreSet'],components['schemas']['ScoreCalibration']) for improved type safety and code clarity. [1] [2] [3]Sorting and utility method updates: